xtest: regression 4005: test aes-gcm overflow on A64#817
Merged
Conversation
jforissier
reviewed
Jun 4, 2026
MingyenHung
force-pushed
the
overflow-of-aes-gcm-on-A64
branch
from
1ce5172 to
f461414
Compare
Contributor
|
|
Set the input size of the new test case to 17 bytes (1 byte + 1 block). This forces internal_aes_gcm_update_payload_blocks() to bypass update_payload_2block() and fall back to decrypt_pl() instead, to properly trigger and verify the overflow boundary condition. Signed-off-by: Mingyen Hung <mingyen.hung@amlogic.com> Reviewed-by: Jerome Forissier <jerome.forissier@arm.com>
MingyenHung
force-pushed
the
overflow-of-aes-gcm-on-A64
branch
from
f461414 to
316b7bc
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the input size of the new test case to 17 bytes (1 byte + 1 block). This forces internal_aes_gcm_update_payload_blocks() to bypass update_payload_2block() and fall back to decrypt_pl() instead, to properly trigger and verify the overflow boundary condition.
This test case helps to reproduce the counter overflow issue caused by ce_aes_gcm_ctr_encrypt() on ARM64.
Note that for the ARM32 case, the same issue can already be reproduced simply by running
xtest -t regression 4005.