[16.0][FWP][ADD] shopfloor_reception_refund_return by mt-software-de · Pull Request #1060 · OCA/wms

mt-software-de · 2025-06-22T11:56:42Z

OCA-git-bot · 2025-06-22T11:56:46Z

Hi @sebalix, @guewen, @mmequignon, @JuMiSanAr, @simahawk,
some modules you are maintaining are being modified, check this out!

jbaudoux

You need to change shopfloor_reception version in manifest and put that version for the pre-migration

mt-software-de · 2025-06-23T07:09:40Z

You need to change shopfloor_reception version in manifest and put that version for the pre-migration

yes of course. thx

jbaudoux · 2025-06-23T07:46:13Z

@mt-software-de pre-commit is red

mt-software-de · 2025-06-23T08:57:50Z

@mt-software-de pre-commit is red

done

jbaudoux · 2025-06-23T10:27:17Z

@mt-software-de you need to split one module per commit

mt-software-de · 2025-06-23T11:56:20Z

@mt-software-de you need to split one module per commit

done

jbaudoux · 2025-06-24T11:19:55Z

@mt-software-de you need to split one module per commit

done

@mt-software-de it is not yet right, one commit is still on 2 modules

mt-software-de · 2025-06-24T11:25:41Z

@mt-software-de you need to split one module per commit

done

@mt-software-de it is not yet right, one commit is still on 2 modules

That are the forward ported ones from #870
I could fix them via #1059 but therefore #870 needs to be closed.

jbaudoux · 2025-06-24T11:28:08Z

@mt-software-de it is not yet right, one commit is still on 2 modules

That are the forward ported ones from #870 I could fix them via #1059 but therefore #870 needs to be closed.

yes let's do that otherwise it makes it complicate to include in v18 migration

mt-software-de · 2025-06-24T12:56:03Z

@mt-software-de it is not yet right, one commit is still on 2 modules

That are the forward ported ones from #870 I could fix them via #1059 but therefore #870 needs to be closed.

yes let's do that otherwise it makes it complicate to include in v18 migration

OK everything is ready.
#870 can be closed
and is replaced #1059

jbaudoux · 2025-06-24T14:10:54Z

yes let's do that otherwise it makes it complicate to include in v18 migration

OK everything is ready. #870 can be closed and is replaced #1059

the pre migration script is there twice and you need also to increase the version of shopfloor as it's all in the same PR

… shopfloor

…fund

mt-software-de · 2025-06-24T14:19:38Z

@mt-software-de it is not yet right, one commit is still on 2 modules

That are the forward ported ones from #870 I could fix them via #1059 but therefore #870 needs to be closed.

yes let's do that otherwise it makes it complicate to include in v18 migration

OK everything is ready. #870 can be closed and is replaced #1059

Yes of course. Thx. Done.

jbaudoux · 2025-06-24T16:47:32Z

/ocabot merge nobump

OCA-git-bot · 2025-06-24T16:47:40Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1060-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot · 2025-06-24T17:10:06Z

Congratulations, your PR was merged at e26cf83. Thanks a lot for contributing to OCA. ❤️

giarve · 2025-06-24T17:50:20Z

Hi.

Got this running module upgrade:

2025-06-24 17:46:34,193 1 ERROR ? click_odoo.env_options: exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/click_odoo/env_options.py", line 194, in _invoke
    with self.environment_manager(
  File "/usr/local/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.10/site-packages/click_odoo_contrib/update.py", line 299, in OdooEnvironmentWithUpdate
    _update_db(
  File "/usr/local/lib/python3.10/site-packages/click_odoo_contrib/update.py", line 270, in _update_db
    _update_db_nolock(
  File "/usr/local/lib/python3.10/site-packages/click_odoo_contrib/update.py", line 248, in _update_db_nolock
    odoo.modules.registry.Registry.new(database, update_module=True)
  File "<decorator-gen-16>", line 2, in new
  File "/opt/odoo/custom/src/odoo/odoo/tools/func.py", line 87, in locked
    return func(inst, *args, **kwargs)
  File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 87, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 489, in load_modules
    processed_modules += load_marked_modules(cr, graph,
  File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 374, in load_marked_modules
    loaded, processed = load_module_graph(
  File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 185, in load_module_graph
    migrations.migrate_module(package, 'pre')
  File "/opt/odoo/custom/src/odoo/odoo/modules/migration.py", line 170, in migrate_module
    exec_script(self.cr, installed_version, pyfile, pkg.name, stage, stageformat[stage] % version)
  File "/opt/odoo/custom/src/odoo/odoo/modules/migration.py", line 188, in exec_script
    migrate(cr, installed_version)
  File "/opt/odoo/auto/addons/shopfloor_reception/migrations/16.0.1.2.0/pre-migration.py", line 17, in migrate
    move_fields_to_new_module(cr)
  File "/opt/odoo/auto/addons/shopfloor_reception/migrations/16.0.1.2.0/pre-migration.py", line 11, in move_fields_to_new_module
    openupgrade.update_module_moved_fields(
  File "/usr/local/lib/python3.10/site-packages/openupgradelib/openupgrade.py", line 3285, in update_module_moved_fields
    do_raise("moved_fields %s must be a tuple or list!" % moved_fields)
  File "/usr/local/lib/python3.10/site-packages/openupgradelib/openupgrade.py", line 129, in do_raise
    raise UserError(error)
odoo.exceptions.UserError: moved_fields is_shopfloor_created must be a tuple or list!
Error: moved_fields is_shopfloor_created must be a tuple or list!

mt-software-de · 2025-06-24T18:30:03Z

Hi.

Got this running module upgrade:

2025-06-24 17:46:34,193 1 ERROR ? click_odoo.env_options: exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/click_odoo/env_options.py", line 194, in _invoke
    with self.environment_manager(
  File "/usr/local/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.10/site-packages/click_odoo_contrib/update.py", line 299, in OdooEnvironmentWithUpdate
    _update_db(
  File "/usr/local/lib/python3.10/site-packages/click_odoo_contrib/update.py", line 270, in _update_db
    _update_db_nolock(
  File "/usr/local/lib/python3.10/site-packages/click_odoo_contrib/update.py", line 248, in _update_db_nolock
    odoo.modules.registry.Registry.new(database, update_module=True)
  File "<decorator-gen-16>", line 2, in new
  File "/opt/odoo/custom/src/odoo/odoo/tools/func.py", line 87, in locked
    return func(inst, *args, **kwargs)
  File "/opt/odoo/custom/src/odoo/odoo/modules/registry.py", line 87, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 489, in load_modules
    processed_modules += load_marked_modules(cr, graph,
  File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 374, in load_marked_modules
    loaded, processed = load_module_graph(
  File "/opt/odoo/custom/src/odoo/odoo/modules/loading.py", line 185, in load_module_graph
    migrations.migrate_module(package, 'pre')
  File "/opt/odoo/custom/src/odoo/odoo/modules/migration.py", line 170, in migrate_module
    exec_script(self.cr, installed_version, pyfile, pkg.name, stage, stageformat[stage] % version)
  File "/opt/odoo/custom/src/odoo/odoo/modules/migration.py", line 188, in exec_script
    migrate(cr, installed_version)
  File "/opt/odoo/auto/addons/shopfloor_reception/migrations/16.0.1.2.0/pre-migration.py", line 17, in migrate
    move_fields_to_new_module(cr)
  File "/opt/odoo/auto/addons/shopfloor_reception/migrations/16.0.1.2.0/pre-migration.py", line 11, in move_fields_to_new_module
    openupgrade.update_module_moved_fields(
  File "/usr/local/lib/python3.10/site-packages/openupgradelib/openupgrade.py", line 3285, in update_module_moved_fields
    do_raise("moved_fields %s must be a tuple or list!" % moved_fields)
  File "/usr/local/lib/python3.10/site-packages/openupgradelib/openupgrade.py", line 129, in do_raise
    raise UserError(error)
odoo.exceptions.UserError: moved_fields is_shopfloor_created must be a tuple or list!
Error: moved_fields is_shopfloor_created must be a tuple or list!

I will prepare a fix for it.

jbaudoux requested changes Jun 23, 2025

View reviewed changes

mt-software-de force-pushed the 16-add-shopfloor_reception_refund_return branch from 9a659ca to c6ac389 Compare June 23, 2025 07:09

jbaudoux approved these changes Jun 23, 2025

View reviewed changes

mt-software-de force-pushed the 16-add-shopfloor_reception_refund_return branch from c6ac389 to bd4c1f6 Compare June 23, 2025 08:57

mt-software-de force-pushed the 16-add-shopfloor_reception_refund_return branch from bd4c1f6 to a007507 Compare June 23, 2025 11:56

mt-software-de mentioned this pull request Jun 24, 2025

[14.0][ADD] shopfloor_reception_refund_return #1059

Merged

mt-software-de force-pushed the 16-add-shopfloor_reception_refund_return branch from a007507 to f95d541 Compare June 24, 2025 12:54

mmequignon and others added 5 commits June 24, 2025 16:14

[IMP] shopfloor: stock.picking add flag is_shopfloor_created

2107c6a

[IMP] shopfloor_reception: Move stock.picking is_shopfloor_created to…

26519b1

… shopfloor

[ADD] shopfloor_reception_refund_return: Mark created return as to re…

80face5

…fund

[MIG] shopfloor_reception: Migration to Version 16.0 for FWP of OCA#870

3111c72

[MIG] shopfloor_reception_refund_return: Migration to Version 16.0

4f9986d

mt-software-de force-pushed the 16-add-shopfloor_reception_refund_return branch from f95d541 to 4f9986d Compare June 24, 2025 14:14

OCA-git-bot added the bot is merging ⏳ label Jun 24, 2025

OCA-git-bot merged commit fc62e3f into OCA:16.0 Jun 24, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 24, 2025

mt-software-de mentioned this pull request Jun 24, 2025

[16.0][FIX] shopfloor_reception: Fix migration stock.picking is_shopfloor_created #1065

Merged

Uh oh!

Uh oh!

Conversation

mt-software-de commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Jun 22, 2025

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

mt-software-de commented Jun 23, 2025

Uh oh!

jbaudoux commented Jun 23, 2025

Uh oh!

mt-software-de commented Jun 23, 2025

Uh oh!

jbaudoux commented Jun 23, 2025

Uh oh!

mt-software-de commented Jun 23, 2025

Uh oh!

jbaudoux commented Jun 24, 2025

Uh oh!

mt-software-de commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbaudoux commented Jun 24, 2025

Uh oh!

mt-software-de commented Jun 24, 2025

Uh oh!

jbaudoux commented Jun 24, 2025

Uh oh!

mt-software-de commented Jun 24, 2025

Uh oh!

jbaudoux commented Jun 24, 2025

Uh oh!

OCA-git-bot commented Jun 24, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jun 24, 2025

Uh oh!

giarve commented Jun 24, 2025

Uh oh!

mt-software-de commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mt-software-de commented Jun 22, 2025 •

edited

Loading

mt-software-de commented Jun 24, 2025 •

edited

Loading