[18.0] [MIG] stock_mts_mto_rule : migrate to 18.0 by apik-mgu · Pull Request #2425 · OCA/stock-logistics-warehouse

apik-mgu · 2025-09-12T07:45:05Z

No description provided.

… procurement rules to handle the mts+mto scenario

Add explanation for finding this setting

Conforms to the latest README template: bugtracker, runbot etc. Fixes bugtracker URL on some modules. States OCA as maintainer, removes other contributors from the 'Maintainer' section.

…en warehouse is two/three steps delivery propagate move by mts-mto in pick/pack/out

OCA Transbot updated translations from Transifex

…least another procurement

…unit tests

There's a traceback when renaming warehouse code (without renaming warehouse name), as name argument is False.

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

This method is called from the write() method the one how support multiple records an api.multi method. I was making some test when I tried to activate the mto+mts option for multiple warehouse and the next error appears: ``ValueError: Expected singleton`` In order to fix this error I only added a loop to manage the multiple registers.

OCA Transbot updated translations from Transifex

Major changes to the way Warehouses update their routes/rules and self heal. Improved rule code to use `float_compare` and `float_is_zero`.

Currently translated at 11.8% (2 of 17 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_mts_mto_rule Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_mts_mto_rule/fr_FR/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_mts_mto_rule Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_mts_mto_rule/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_mts_mto_rule Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_mts_mto_rule/

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-stock_mts_mto_rule Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-stock_mts_mto_rule/it/

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-stock_mts_mto_rule Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-stock_mts_mto_rule/es/

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-17.0/stock-logistics-warehouse-17.0-stock_mts_mto_rule Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-17-0/stock-logistics-warehouse-17-0-stock_mts_mto_rule/it/

rousseldenis · 2025-09-19T10:57:41Z

/ocabot migration stock_mts_mto_rule

rousseldenis · 2025-09-19T10:59:48Z

            ]
        )
-        self.assertEqual(1, len(move_mts))
+        # self.assertEqual(1, len(move_mts))


Why removing this ?

Source reviewed and control reinstated

ypapouin · 2025-12-17T14:18:34Z

Something is broken somewhere, you changed the test_mts_mto_route_mto_only assertion to pass the test but the global behaviour is really strange. I ran the same test with Odoo 14.0 to compare moves data:

Odoo 14.0:

[{'id': N,
  'location_dest_id': (5, 'Partner Locations/Customers'),
  'location_id': (8, 'WH/Stock'),
  'move_dest_ids': [],
  'move_orig_ids': [N+1]}]

[{'id': N+1,
  'location_dest_id': (8, 'WH/Stock'),
  'location_id': (4, 'Partner Locations/Vendors'),
  'move_dest_ids': [N],
  'move_orig_ids': []}]

graph LR
    subgraph v14 [Odoo 14 Flow]
        direction LR
        V14_Vendor(Vendors)
        V14_Stock(WH/Stock)
        V14_Customer(Customers)

        V14_Vendor -- "Move N+1<br/>(Supply)" --> V14_Stock
        V14_Stock -- "Move N<br/>(Delivery)" --> V14_Customer
    end

Odoo 18.0:

[{'id': N+1,
  'location_dest_id': (5, 'Partners/Customers'),
  'location_final_id': (8, 'WH/Stock'),
  'location_id': (4, 'Partners/Vendors'),
  'move_dest_ids': [N],
  'move_orig_ids': []}]

[{'id': N,
  'location_dest_id': (5, 'Partners/Customers'),
  'location_final_id': (5, 'Partners/Customers'),
  'location_id': (8, 'WH/Stock'),
  'move_dest_ids': [],
  'move_orig_ids': [N+1]}]

graph LR
    subgraph v18 [Odoo 18 Flow]
        direction LR
        V18_Vendor(Vendors)
        V18_Stock(WH/Stock)
        V18_Customer(Customers)

        %% The main difference: Move N+1 points to Customer in location_dest_id
        V18_Vendor -- "Move N+1<br/>(Supply)<br/>Dest: Customers" --> V18_Customer
        
        %% The delivery move
        V18_Stock -- "Move N<br/>(Delivery)" --> V18_Customer

        %% Dotted line representing location_final_id
        V18_Vendor -.-> |"Move N+1<br/>Final: WH/Stock"| V18_Stock
    end

    %% Highlight the changed path in red
    linkStyle 0 stroke:#ffff00,stroke-width:3px,color:yellow;
    linkStyle 2 stroke:#00AAff,stroke-width:2px,stroke-dasharray:

With Odoo 18.0, both moves have the same location_dest_id.
I will continue to investigate on this.

ypapouin · 2025-12-17T16:14:52Z

It looks like it is related to Odoo changes from odoo/odoo@11e6987 ([REF] stock: pull & push rules refactor) with introduction of the location_final_id and that made location_dest_id a non-readonly computed field.

ypapouin · 2025-12-17T16:49:25Z

+                )
+                == 0.0
+            ):
+                getattr(self.env["stock.rule"], f"_run_{rule.mts_rule_id.action}")(


mts_rule_id -> mto_rule_id

ypapouin · 2025-12-17T16:49:47Z

+                moves_to_assign._action_assign()
+
+                mto_procurement = procurement._replace(product_qty=needed_qty)
+                getattr(self.env["stock.rule"], f"_run_{rule.mts_rule_id.action}")(


mts_rule_id -> mto_rule_id

ypapouin · 2025-12-17T17:36:21Z

+        rule_vals = {
+            "location_dest_id": self.env.ref("stock.stock_location_stock").id,
+            "location_src_id": self.env.ref("stock.stock_location_suppliers").id,
+            "action": "pull",
+            "warehouse_id": self.warehouse.id,
+            "picking_type_id": self.env.ref("stock.picking_type_out").id,
+            "name": "dummy rule",
+            "route_id": self.dummy_route.id,
+        }


Add:

"location_dest_from_rule": True,

Fix:
from supplier to stock => in

"picking_type_id": self.env.ref("stock.picking_type_in").id,

github-actions · 2026-04-19T13:04:47Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

BhaveshHeliconia · 2026-05-07T06:00:17Z

@apik-mgu could you please address @ypapouin’s comments?

ypapouin · 2026-05-18T16:01:12Z

@BhaveshHeliconia, I made a new PR for this module:

[18.0][MIG] stock_mts_mto_rule: Migration to 18.0 #2489

florian-dacosta and others added 30 commits September 11, 2025 12:29

refactore creating a new route, a new procurement action and separate…

9a0d115

… procurement rules to handle the mts+mto scenario

add test + use standard mts and mto rules

4c89a4c

Better readme in stock_mts_mto_rule

b64d0b9

OCA Transbot updated translations from Transifex

c909da6

[UPD] prefix versions with 8.0

47e15c1

[MIG] Make modules uninstallable

46ed17a

Update README.rst

68c38b8

Add explanation for finding this setting

[FIX] remove en.po that was erroneously created by transbot

176133a

[MIG] Rename manifest files

55da108

fix stock_mts_mto procurement check method

70c7ba7

OCA Transbot updated translations from Transifex

05b1d5d

Update READMEs

f4aef95

Conforms to the latest README template: bugtracker, runbot etc. Fixes bugtracker URL on some modules. States OCA as maintainer, removes other contributors from the 'Maintainer' section.

set pull rule of customer location like split_procurement to allow wh…

48b74f0

…en warehouse is two/three steps delivery propagate move by mts-mto in pick/pack/out

OCA Transbot updated translations from Transifex

35d21f7

OCA Transbot updated translations from Transifex

stock move name fix

47b02b5

Do no run mts mto procurement if it already has been splited into at …

223de33

…least another procurement

stock_mts_mto_rule

6f9931d

[MIG] Migrate stock_mts_mto_rule to v10.0

810af69

[IMP] stock_mts_mto_rule : Added some unit tests

c1d76fd

[FIX] stock_mts_mto_rule : Fixed v10 migration bugs, revealed by new …

24d7080

…unit tests

OCA Transbot updated translations from Transifex

c099ea5

[FIX] stock_mts_mto_rule: Don't fail on renaming WH code

d5ba935

There's a traceback when renaming warehouse code (without renaming warehouse name), as name argument is False.

OCA Transbot updated translations from Transifex

71553b4

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

65b1a90

OCA Transbot updated translations from Transifex

Migrate stock_mts_mto_rule to version 11

1fc270f

[ADD] icon.png

94e6a9d

[MIG] Migrate stock_mts_mto_rule to 12.0

a2cec5f

Major changes to the way Warehouses update their routes/rules and self heal. Improved rule code to use `float_compare` and `float_is_zero`.

weblate and others added 11 commits September 11, 2025 12:29

[UPD] README.rst

cdfca0b

[IMP] stock_mts_mto_rule: pre-commit auto fixes

dfb5cd2

[17.0][MIG] stock_mts_mto_rule: Migration to 17.0

8358761

[UPD] Update stock_mts_mto_rule.pot

e84b3a5

[BOT] post-merge updates

5e54c81

[IMP] stock_mts_mto_rule: Fix company_id for demo data

190941b

[BOT] post-merge updates

aa6a26d

apik-mgu mentioned this pull request Sep 12, 2025

Migration to version 18.0 #2170

Open

72 tasks

OCA-git-bot added this to the 18.0 milestone Sep 19, 2025

rousseldenis added needs review migration labels Sep 19, 2025

rousseldenis reviewed Sep 19, 2025

View reviewed changes

itms-pynho mentioned this pull request Sep 26, 2025

[18.0] stock_mts_mto_rule: MTS + MTO Does Not Auto-Create MOs for BOM Components #2433

Closed

[MIG] stock_mts_mto_rule: Migration to 18.0

9685e62

apik-mgu force-pushed the 18.0-mig-stock_mts_mto_rule branch from 156798c to 9685e62 Compare September 29, 2025 10:10

ypapouin suggested changes Dec 17, 2025

View reviewed changes

ypapouin reviewed Dec 17, 2025

View reviewed changes

ypapouin mentioned this pull request Dec 18, 2025

[18.0][MIG] stock_mts_mto_rule: Migration to 18.0 #2489

Merged

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 19, 2026

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 10, 2026

Uh oh!

Uh oh!

Conversation

apik-mgu commented Sep 12, 2025

Uh oh!

rousseldenis commented Sep 19, 2025

Uh oh!

rousseldenis Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

apik-mgu Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ypapouin commented Dec 17, 2025

Uh oh!

ypapouin commented Dec 17, 2025

Uh oh!

ypapouin Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

ypapouin Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

ypapouin Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

BhaveshHeliconia commented May 7, 2026

Uh oh!

ypapouin commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants