[18.0][MIG] stock_inventory_valuation_report by oscars8a · Pull Request #472 · OCA/stock-logistics-reporting

oscars8a · 2026-02-13T13:12:15Z

No description provided.

rrebollo · 2026-03-23T21:22:55Z

@oscars8a please respect the commit history. Review the wiki documentation or other resources to ensure the migration is done properly. https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

rrebollo · 2026-03-26T12:19:12Z

@oscars8a When I mentioned commit history, I was referring to past versions. What we have now is essentially the history of this migration—which, by the way, you should squash (get rid of).

Here's another resource to help with migrations: https://github.com/OCA/oca-port. Be sure to check out the video tutorials about it from OCA Days events on YouTube.

… currently not available products

Currently translated at 100.0% (39 of 39 strings) Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_inventory_valuation_report Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_inventory_valuation_report/it/

Co-authored-by: dessanhemrayev <dessanhemrayev@gmail.com> Co-authored-by: Alessandro Uffreduzzi <alessandro.uffreduzzi@pytech.it>

…eport

Currently translated at 100.0% (39 of 39 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_inventory_valuation_report Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_inventory_valuation_report/it/

…ger while running tests

oscars8a · 2026-03-26T12:44:45Z

Thank you very much for your help, @rrebollo

rrebollo · 2026-03-26T13:20:34Z

The title of this PR should be something along the lines of:

[18.0][MIG] stock_inventory_valuation_report

In the description, you should mention the corresponding issue where migrations for the target version are listed. This ensures all contributors can see you've stepped in to handle the migration and helps avoid duplicate work, in this case: #346.

I also noticed this addon hasn't been migrated since version 14.0. Typically, that would suggest it's no longer needed—either because its functionality was merged into the built-in modules or because another OCA addon now provides the same feature.

Did your research consider that possibility?

rrebollo · 2026-03-26T13:25:17Z

this file shouldn't be part of the migration

Yes, but it’s the only way I’ve seen to fix the precommit, https://github.com/OCA/stock-logistics-reporting/actions/runs/23599897085/job/68726677853?pr=472

The real problem could be linked to the copier repo template—maybe it needs to be updated. Remove the file and leave a message explaining that the failing test is unrelated to the addon migration.

Had you tried git pull --rebase origin 18.0?

It's up to date; I updated it two weeks ago. The problem was specifying the file as an ESM module.

rrebollo

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

For example you could replace deprecated t-esc by t-out in some templates.

rrebollo · 2026-04-07T16:04:44Z

+from odoo.tools import mute_logger, test_reports
+
+
+class TestStockInventoryValuation(common.TransactionCase):


Use BaseCommon instead. You can check out the source code and adopt it if the benefits apply.

Thank you very much for your help and patience

JorgeQuinteros

LGTM Functional Review.

OCA-git-bot · 2026-04-16T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia

Could you please squash these two commits into the migration commit?

oscars8a · 2026-05-07T14:15:12Z

Could you please squash these two commits into the migration commit?

Thanks, you've already done it. Best regards,

OCA-git-bot · 2026-05-08T04:35:56Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2026-05-08T04:35:56Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2026-05-08T04:35:59Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

oscars8a changed the title ~~18.0 mig stock inventory valuation report~~ [18.0] [MIG] stock inventory valuation report Mar 11, 2026

oscars8a changed the title ~~[18.0] [MIG] stock inventory valuation report~~ [18.0][MIG] stock inventory valuation report Mar 11, 2026

oscars8a mentioned this pull request Mar 17, 2026

[14.0][ERROR][stock_inventory_valuation_report] product.standart_price does not refer to the cost on a specific day, but to the current cost. #486

Open

oscars8a force-pushed the 18.0-mig-stock_inventory_valuation_report branch from f961621 to 8770977 Compare March 18, 2026 13:08

oscars8a force-pushed the 18.0-mig-stock_inventory_valuation_report branch 3 times, most recently from e726df3 to 9a84ee8 Compare March 26, 2026 12:16

ps-tubtim and others added 18 commits March 26, 2026 13:30

[12.0][ADD]stock_inventory_valuation_report

5a50a3c

[FIX] Standard price incorrectly calculated on historic value

8b86b1d

[ADD] Reference and Barcode column in stock inventory valuation report

721c03e

Added translation using Weblate (Slovenian)

1f8a78a

Added translation using Weblate (Portuguese)

f7722ed

Added translation using Weblate (French)

365ab22

[FIX] stock_inventory_valuation_report: show quantity in the past for…

d224588

… currently not available products

Added translation using Weblate (Italian)

f849854

[IMP] stock_inventory_valuation_report: black, isort, prettier

a1c8de1

[MIG] stock_inventory_valuation_report: Migration to 14.0

42f1fe5

Co-authored-by: dessanhemrayev <dessanhemrayev@gmail.com> Co-authored-by: Alessandro Uffreduzzi <alessandro.uffreduzzi@pytech.it>

[IMP] stock_inventory_valuation_report: don't print today's date in r…

ac5eb6e

…eport

[IMP] stock_inventory_valuation_report: print variant name in report

2cd5374

[IMP] stock_inventory_valuation_report: print UoM in PDF and XLSX

d53ce13

[UPD] Update stock_inventory_valuation_report.pot

7d44910

[FIX] stock_inventory_valuation_report: mute test report warnning log…

4fa20a5

…ger while running tests

[BOT] post-merge updates

8874308

oscars8a force-pushed the 18.0-mig-stock_inventory_valuation_report branch 2 times, most recently from 8db58c7 to 01fcf5e Compare March 26, 2026 12:36

rrebollo reviewed Mar 26, 2026

View reviewed changes

rrebollo suggested changes Mar 26, 2026

View reviewed changes

Comment thread stock_inventory_valuation_report/wizard/stock_quantity_history.py Outdated

Comment thread stock_inventory_valuation_report/wizard/stock_quantity_history.py Outdated

oscars8a changed the title ~~[18.0][MIG] stock inventory valuation report~~ [18.0][MIG] stock_inventory_valuation_report Mar 26, 2026

oscars8a mentioned this pull request Mar 26, 2026

Migration to version 18.0 #346

Open

23 tasks

oscars8a force-pushed the 18.0-mig-stock_inventory_valuation_report branch from 6463555 to 48eddd5 Compare March 26, 2026 14:30

rrebollo approved these changes Apr 7, 2026

View reviewed changes

JorgeQuinteros approved these changes Apr 16, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 16, 2026

BhaveshHeliconia suggested changes Apr 23, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 23, 2026

[MIG] stock_inventory_valuation_report: Migration to 18.0

99d3610

oscars8a force-pushed the 18.0-mig-stock_inventory_valuation_report branch from a0f358a to 99d3610 Compare May 7, 2026 14:01

OCA-git-bot added series:18.0 mod:stock_inventory_valuation_report Module stock_inventory_valuation_report labels May 7, 2026

oscars8a requested a review from BhaveshHeliconia May 7, 2026 14:14

BhaveshHeliconia approved these changes May 8, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels May 8, 2026

		from odoo.tools import mute_logger, test_reports


		class TestStockInventoryValuation(common.TransactionCase):

Uh oh!

Conversation

oscars8a commented Feb 13, 2026

Uh oh!

rrebollo commented Mar 23, 2026

Uh oh!

rrebollo commented Mar 26, 2026

Uh oh!

oscars8a commented Mar 26, 2026

Uh oh!

rrebollo commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rrebollo Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

oscars8a Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rrebollo Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rrebollo Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

oscars8a Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

oscars8a Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

JorgeQuinteros left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 16, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

oscars8a commented May 7, 2026

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

rrebollo commented Mar 26, 2026 •

edited

Loading