[18.0][MIG] stock_picking_report_delivery_custom_name#469
Open
Andrii9090-tecnativa wants to merge 5 commits into
Open
[18.0][MIG] stock_picking_report_delivery_custom_name#469Andrii9090-tecnativa wants to merge 5 commits into
Andrii9090-tecnativa wants to merge 5 commits into
Conversation
Andrii9090-tecnativa
force-pushed
the
18.0-mig-stock_picking_report_delivery_custom_name
branch
4 times, most recently
from
3ecd04a to
153bb48
Compare
Andrii9090-tecnativa
force-pushed
the
18.0-mig-stock_picking_report_delivery_custom_name
branch
from
b3d2699 to
f306c1b
Compare
Andrii9090-tecnativa
force-pushed
the
18.0-mig-stock_picking_report_delivery_custom_name
branch
from
f306c1b to
d589033
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Just a minor suggestion: could we use BaseCommon here? That way, we wouldn’t need to create a res.partner record.
| from odoo.tools import html2plaintext | ||
|
|
||
|
|
||
| class TestStockPickingReportCustomName(common.TransactionCase): |
Contributor
There was a problem hiding this comment.
Suggested change
| class TestStockPickingReportCustomName(common.TransactionCase): | |
| class TestStockPickingReportCustomName(Basecommon): |
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.customer = cls.env["res.partner"].create({"name": "Mr. Odoo"}) |
Contributor
There was a problem hiding this comment.
Suggested change
| cls.customer = cls.env["res.partner"].create({"name": "Mr. Odoo"}) |
|
|
||
| <!-- /!\ do not modify above this line --> | ||
|
|
||
| <<<<<<< before updating |
Contributor
There was a problem hiding this comment.
There is a conflict occurring here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straightforward migration to 18
And delivery slip
@moduon
MT-13230