[16.0][IMP] hr_holidays_public: remove redundant partner resolution in is_public_holiday#259
Open
RicardCForgeFlow wants to merge 1 commit into
Open
[16.0][IMP] hr_holidays_public: remove redundant partner resolution in is_public_holiday#259RicardCForgeFlow wants to merge 1 commit into
RicardCForgeFlow wants to merge 1 commit into
Conversation
RicardCForgeFlow
changed the title
RicardCForgeFlow
force-pushed
the
16.0-imp-hr_holidays_public
branch
from
1af2d38 to
1fceaaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify is_public_holiday by removing the redundant call to _get_partner_deprecated_employee, as it is already invoked immediately after inside get_holidays_list:
So we correct the Warning:
