[FIX] helpdesk_mgmt: Prevent duplicate ticket submission#1036
Open
shirashi3771 wants to merge 1 commit into
Open
[FIX] helpdesk_mgmt: Prevent duplicate ticket submission#1036shirashi3771 wants to merge 1 commit into
shirashi3771 wants to merge 1 commit into
Conversation
|
Hi @shirashi3771, could you please add tests for this case? |
ppyczko
suggested changes
Jun 11, 2026
ppyczko
left a comment
ppyczko
left a comment
There was a problem hiding this comment.
I've tested this in Runboat and, at the moment, it isn't possible to create a ticket from the portal.
When pressing the "Submit Ticket" button, by the time _onSubmit is executed, btn.disabled is already true, so this block is triggered:
As a result, the form submission is prevented and no POST request is sent.
This is probably due to your code conflicting with this change: https://github.com/OCA/helpdesk/pull/948/changes
This inline onsubmit disables the button before your _onSubmit runs, therefore, interprets the very first submission as a duplicate submission and cancels it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent duplicate ticket submissions by disabling the submit button after the first click.
cc https://github.com/APSL 48227
@mpascuall @lbarry-apsl @miquelalzanillas @peluko00 @BernatObrador @cubells @palomagrc93 @ppyczko @isugac @javierobcn @LlucSG please review.