Skip to content

[19.0][MIG] helpdesk_timesheet_time_type: Migration to 19.0#1013

Open
mpascuall wants to merge 15 commits into
OCA:19.0from
APSL:19.0-mig-helpdesk_timesheet_time_type
Open

[19.0][MIG] helpdesk_timesheet_time_type: Migration to 19.0#1013
mpascuall wants to merge 15 commits into
OCA:19.0from
APSL:19.0-mig-helpdesk_timesheet_time_type

Conversation

@mpascuall

Copy link
Copy Markdown
Contributor

@OCA-git-bot OCA-git-bot added series:19.0 mod:helpdesk_timesheet_time_type Module helpdesk_timesheet_time_type labels May 26, 2026
@mpascuall mpascuall force-pushed the 19.0-mig-helpdesk_timesheet_time_type branch from 9624c30 to b8f22dd Compare May 26, 2026 12:51
@mpascuall mpascuall force-pushed the 19.0-mig-helpdesk_timesheet_time_type branch from b8f22dd to 97fc17f Compare May 26, 2026 12:55

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpascuall you also need to add this PR in test-requirements.txt:
OCA/timesheet#824

That module is also listed in the dependencies, and it has an open PR as well.

@mpascuall mpascuall force-pushed the 19.0-mig-helpdesk_timesheet_time_type branch from 97fc17f to 4bb9072 Compare May 29, 2026 14:47

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this dependency, as helpdesk_mgmt_project depends on it:

Comment thread test-requirements.txt
@mpascuall mpascuall force-pushed the 19.0-mig-helpdesk_timesheet_time_type branch from 4bb9072 to 0b6f796 Compare June 1, 2026 06:15
@mpascuall mpascuall force-pushed the 19.0-mig-helpdesk_timesheet_time_type branch from 0b6f796 to 1077e5a Compare June 1, 2026 09:17

@peluko00 peluko00 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbarry-apsl lbarry-apsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, LGTM

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants