[18.0][MIG] helpdesk_mgmt_stock: Migration to 18.0#1008
Open
david-banon-tecnativa wants to merge 10 commits into
Open
[18.0][MIG] helpdesk_mgmt_stock: Migration to 18.0#1008david-banon-tecnativa wants to merge 10 commits into
david-banon-tecnativa wants to merge 10 commits into
Conversation
OCA-git-bot
added
series:18.0
mod:helpdesk_product
david-banon-tecnativa
force-pushed
the
18.0-mig-helpdesk_mgmt_stock
branch
from
0671e74 to
0636de5
Compare
ChristianSantamaria
suggested changes
May 26, 2026
ChristianSantamaria
left a comment
ChristianSantamaria
left a comment
There was a problem hiding this comment.
Funcional and code review, LGTM 👍 👍
But i detect a minor changes:
| <field name="inherit_id" ref="stock.view_picking_move_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="/list/field[@name='product_uom']" position="after"> | ||
| <field name="helpdesk_ticket_count" invisible="1" /> |
There was a problem hiding this comment.
Missing fields used in expressions (invisible, column_invisible, readonly, required, context, domain) are now added to the views as invisible ones automatically. If you encounter fields in views with invisible="True" or invisible="1", they can probably be removed for cleanliness, as they are auto-added. Reference: odoo/odoo#137031.
Suggested change
| <field name="helpdesk_ticket_count" invisible="1" /> |
Contributor
Author
There was a problem hiding this comment.
Had it on my mind for v19, didn't know it was already implemented in v18, thanks!
Comment on lines
+35
to
+36
| <field name="helpdesk_ticket_count" invisible="1" /> | ||
| <field name="helpdesk_ticket_allowed" invisible="1" /> |
There was a problem hiding this comment.
Same
Suggested change
| <field name="helpdesk_ticket_count" invisible="1" /> | |
| <field name="helpdesk_ticket_allowed" invisible="1" /> |
Comment on lines
+11
to
+12
| help="Check this if you want to authorize helpdesk ticket creation" | ||
| "for this picking type operations.", |
There was a problem hiding this comment.
Minor change for not collapse words
Suggested change
| help="Check this if you want to authorize helpdesk ticket creation" | |
| "for this picking type operations.", | |
| help="Check this if you want to authorize helpdesk ticket creation " | |
| "for this picking type operations.", |
Contributor
Author
There was a problem hiding this comment.
Added
Labels went missing in form view due to a new group being created inside an already existing group (odoo only renders the labels for leaf groups).
Add the "action" prefix to the method called by the wizard "Create Ticket" button in order to signify more clearly that this returns an action.
Pass default picking/move id in context of the different tickets views opened in order to allow to pre-populate those fields when the user creates a new ticket from there.
david-banon-tecnativa
force-pushed
the
18.0-mig-helpdesk_mgmt_stock
branch
from
0636de5 to
3d772c0
Compare
david-banon-tecnativa
force-pushed
the
18.0-mig-helpdesk_mgmt_stock
branch
from
3d772c0 to
c72d599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A migration from this PR to 18.0, changes:
helpdesk_motivedependencycc @Tecnativa
ping @rousseldenis