[19.0][MIG] crm_partner_required: Migration to 19.0#745
Open
WesleyOliveira98 wants to merge 7 commits into
Open
[19.0][MIG] crm_partner_required: Migration to 19.0#745WesleyOliveira98 wants to merge 7 commits into
WesleyOliveira98 wants to merge 7 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:crm_partner_required
WesleyOliveira98
force-pushed
the
19.0-mig-crm_partner_required
branch
from
92aa2e7 to
fe62731
Compare
WesleyOliveira98
force-pushed
the
19.0-mig-crm_partner_required
branch
from
fe62731 to
3d1036d
Compare
Author
|
Error in tests fixed in #746 |
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Just a minor suggestion: could we use BaseCommon here? That way, we wouldn’t need to create a res.partner record manually.
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestCRMPartnerRequired(TransactionCase): |
Contributor
There was a problem hiding this comment.
Suggested change
| class TestCRMPartnerRequired(TransactionCase): | |
| class TestCRMPartnerRequired(Basecommon): |
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.partner = cls.env["res.partner"].create({"name": "Test Partner"}) |
Contributor
There was a problem hiding this comment.
Suggested change
| cls.partner = cls.env["res.partner"].create({"name": "Test Partner"}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard Migration
cc: @marcelsavegnago @CristianoMafraJunior @kaynnan