Skip to content

[18.0][IMP] account_invoice_report_grouped_by_picking: hides note and section lines.#417

Open
cgarcia-solvos wants to merge 1 commit into
OCA:18.0from
solvosci:18.0-imp-account_invoice_report_grouped_by_picking-report
Open

[18.0][IMP] account_invoice_report_grouped_by_picking: hides note and section lines.#417
cgarcia-solvos wants to merge 1 commit into
OCA:18.0from
solvosci:18.0-imp-account_invoice_report_grouped_by_picking-report

Conversation

@cgarcia-solvos

@cgarcia-solvos cgarcia-solvos commented May 27, 2026

Copy link
Copy Markdown

For grouped by picking invoice report: hides note and section lines.

@OCA-git-bot OCA-git-bot added mod:account_invoice_report_grouped_by_picking Module account_invoice_report_grouped_by_picking series:18.0 labels May 27, 2026
@cgarcia-solvos cgarcia-solvos force-pushed the 18.0-imp-account_invoice_report_grouped_by_picking-report branch from 763ecc9 to 361f793 Compare May 27, 2026 15:00
@cgarcia-solvos

cgarcia-solvos commented May 27, 2026

Copy link
Copy Markdown
Author

@dnplkndll @mmircoli-nexapp could you review? Thanks!!

mmircoli-nexapp
mmircoli-nexapp approved these changes May 27, 2026
View reviewed changes

@mmircoli-nexapp mmircoli-nexapp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CODE REVIEW

@dnplkndll dnplkndll mentioned this pull request May 27, 2026
Open
dnplkndll
dnplkndll approved these changes May 27, 2026
View reviewed changes

@dnplkndll dnplkndll left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

what do you think of implementing at the model versus the view level?
ledoent@801b750

@cgarcia-solvos

cgarcia-solvos commented May 28, 2026

Copy link
Copy Markdown
Author

LGTM

what do you think of implementing at the model versus the view level? ledoent@801b750

Thanks for the review! I agree with your changes, please go ahead

@OCA-git-bot

OCA-git-bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 2, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgarcia-solvos cgarcia-solvos changed the title [18.0][IMP] account_invoice_report_grouped_by_picking [18.0][IMP] account_invoice_report_grouped_by_picking: hides note and section lines. Jun 5, 2026
@cgarcia-solvos @dnplkndll
[IMP] account_invoice_report_grouped_by_picking:
cf86346 
For grouped by picking invoice report: hides note and section lines.

Co-Authored-By: Don Kendall <dkendall@ledoweb.com>
@cgarcia-solvos cgarcia-solvos force-pushed the 18.0-imp-account_invoice_report_grouped_by_picking-report branch from 361f793 to cf86346 Compare June 5, 2026 09:16
@cgarcia-solvos

cgarcia-solvos commented Jun 5, 2026

Copy link
Copy Markdown
Author

Hi @dnplkndll I've applied the changes and added you as a co-author of the commit

@cgarcia-solvos

cgarcia-solvos commented Jun 8, 2026

Copy link
Copy Markdown
Author

@rafaelbn Is this ready to be merged? Thanks!!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jun 8, 2026
pedrobaeza
pedrobaeza requested changes Jun 8, 2026
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to hide them, but to sort it where applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

+3 more reviewers

@dnplkndll dnplkndll dnplkndll approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

@mmircoli-nexapp mmircoli-nexapp mmircoli-nexapp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:account_invoice_report_grouped_by_picking Module account_invoice_report_grouped_by_picking series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@cgarcia-solvos @OCA-git-bot @dnplkndll @pedrobaeza @BhaveshHeliconia @mmircoli-nexapp