[19.0][MIG] account_cutoff_base by alexis-via · Pull Request #357 · OCA/account-closing

alexis-via · 2026-01-19T11:47:22Z

No description provided.

Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy

….get('type', '-')

…de domains) On account.account, type must be <> 'view' and <> 'closed'

…a single warning left ! Add translation template files.

…rted

The signature of existing methods is preserved.

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files

Currently translated at 100,0% (73 of 73 strings) Translation: account-closing-11.0/account-closing-11.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-11-0/account-closing-11-0-account_cutoff_base/de/

Currently translated at 100.0% (133 of 133 strings) Translation: account-closing-17.0/account-closing-17.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-17-0/account-closing-17-0-account_cutoff_base/it/

Currently translated at 100.0% (133 of 133 strings) Translation: account-closing-17.0/account-closing-17.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-17-0/account-closing-17-0-account_cutoff_base/sv/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-17.0/account-closing-17.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-17-0/account-closing-17-0-account_cutoff_base/

Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-17.0/account-closing-17.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-17-0/account-closing-17-0-account_cutoff_base/it/

Add record rules for cutoff lines and cutoff tax lines

On account.cutoff, the domain for the cutoff journal has type='general', like on the default value the accounting config page

…t to Html

Fix license in manifest which was set to LGPL by mistake in the migration commit from v16 to v17

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/

Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/it/

Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/fr/

Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/es_AR/

github-actions · 2026-05-24T13:09:36Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

petrus-v

I'm approving with some improvement suggestions. Also I would love to see more tests in this module, as an independent module it should cover its code.

petrus-v · 2026-06-10T13:19:32Z

+    _check_company_auto = True
+    _description = "Account Cut-off Line"
+
+    parent_id = fields.Many2one("account.cutoff", string="Cut-off", ondelete="cascade")


I would have called it account_cutoff_id, parent/child are mainly used when model is pointing to itself

petrus-v · 2026-06-10T13:35:01Z

+    def _get_mapping_dict(self):
+        """return a dict with:
+        key = ID of account,
+        value = ID of cutoff_account"""
+        self.ensure_one()
+        mappings = self.env["account.cutoff.mapping"].search(
+            Domain(
+                [
+                    ("company_id", "=", self.company_id.id),
+                    ("cutoff_type", "in", ("all", self.cutoff_type)),
+                ]
+            )
+        )


I can see this method is used in account_cutoff_start_and_end dates module but I would rather prepare the mapping record with concerned record only so this method could use an optionnal source accounts.

Suggested change

def _get_mapping_dict(self):

"""return a dict with:

key = ID of account,

value = ID of cutoff_account"""

self.ensure_one()

mappings = self.env["account.cutoff.mapping"].search(

Domain(

[

("company_id", "=", self.company_id.id),

("cutoff_type", "in", ("all", self.cutoff_type)),

]

)

)

def _get_mapping_dict(self, source_accounts=None):

"""return a dict with:

key = ID of account,

value = ID of cutoff_account"""

self.ensure_one()

domain = Domain(

[

("company_id", "=", self.company_id.id),

("cutoff_type", "in", ("all", self.cutoff_type)),

]

)

if source_accounts:

domain &= Domain("account_id", "in", source_accounts.ids)

mappings = self.env["account.cutoff.mapping"].search(

)

AnizR

Thanks for your contribution!

Code LGTM, just some nit picking.

AnizR · 2026-06-11T06:34:15Z

+                                options="{'no_create': True}"
+                                readonly="state == 'done'"
+                            />
+                            <field name="company_currency_id" invisible="1" />


Can be safely removed since odoo/odoo#137031

Suggested change

<field name="company_currency_id" invisible="1" />

AnizR · 2026-06-11T06:35:03Z

+                <field name="cutoff_date" decoration-bf="1" />
+                <field name="move_ref" optional="hide" />
+                <field name="total_cutoff_amount" />
+                <field name="company_currency_id" column_invisible="1" />


Can be safely removed

Suggested change

<field name="company_currency_id" column_invisible="1" />

OCA-git-bot · 2026-06-11T06:45:25Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

petrus-v · 2026-06-11T14:48:24Z

@alexis-via I've propose a PR on top of yours to take care of main reviews here.

the last but not least is the field renaming (parent_id to cutoff_id and cutoff_line_id), I've a commit that do it, it is working but will impact other modules, so do you think we can do it in this version or do you prefer to do it in the next version ?

Alexis de Lattre and others added 30 commits January 19, 2026 12:10

Initial check-in of my cut-off modules

5fcb126

Coding style enhancements (osv.Model -> orm.Model, from . import xxx)

6acb314

Add _prepare functions to allow to inherit before create

f825d4c

Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy

Forgot to move some code to the new _prepare function.

f333c77

Remove the unnecessary "and True or False" after 'xxx' not in context…

b7fb78c

….get('type', '-')

Reduce flake8 warnings (cut lines and comments, space after coma insi…

d3394cc

…de domains) On account.account, type must be <> 'view' and <> 'closed'

My christmas present to the PEP8 fundamentalists : there is not even …

ac01ee4

…a single warning left ! Add translation template files.

all modules unported to odoo 8.0

9ed0e2e

[MIG] move account_cutoff_base and account_cutoff_prepaid out of unpo…

383b78e

…rted

[MIG] account_cutoff: set installable=True

7748f1a

[MIG] account_cutoff_prepaid 8.0

adbd9df

[IMP] account_cutoff_prepaid: add hooks

cc1af60

The signature of existing methods is preserved.

[ADD][account_cutoff_base] Add multi-company record rule

d752c96

Add missing default oca icons

f0c4af1

[UPD] prefix versions with 8.0

deecb6d

[MIG] Make modules uninstallable

f27309f

[MIG] Rename manifest files

85b67ed

Port account_cutoff_base and account_cutoff_prepaid to Odoo v9

e14503b

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Add some hooks that are in 8.0

1e908cc

Take into account the remarks of Pedro:

243f5c9

Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files

Migration of account_cutoff modules to 10.0

8e06033

[FIX] Bad attributes on m2m fields.

984654c

[IMP] Add some tests to improve the code coverage

df98ad3

[MIG] account_cutoff_base: Migration to 11.0

b7f3965

[UPD] Update account_cutoff_base.pot

8d73b38

[MIG] account_cutoff_base: Migration to 12.0

9320fdc

[12.0-mig-account] fixing review comments

ea735d8

[UPD] Update account_cutoff_base.pot

c4e5d31

[FIX] remove titles from readme fragments

0640f14

mymage and others added 20 commits January 19, 2026 12:10

[UPD] Update account_cutoff_base.pot

8995a2a

[IMP] account_cutoff_base: pre-commit auto fixes

5bc8dba

[MIG] account_cutoff_base: migrate to v18

c18da78

Add record rules for cutoff lines and cutoff tax lines

[IMP] account_cutoff_base: compute fields instead of default values

850279e

[IMP] account_cutoff_base: update cutoff journal domain

eaf83fd

On account.cutoff, the domain for the cutoff journal has type='general', like on the default value the accounting config page

[IMP] account_cutoff_base: per-country autoconfiguration of companies

bbf4d86

[IMP] account_cutoff_base: notes field on lines converted to from Tex…

78257af

…t to Html

[FIX] account_cutoff_base: wrong license in manifest

92fed2f

Fix license in manifest which was set to LGPL by mistake in the migration commit from v16 to v17

[UPD] Update account_cutoff_base.pot

642f0ca

[BOT] post-merge updates

595d501

[UPD] Update account_cutoff_base.pot

9d9b38e

[MIG] account_cutoff_base: migrate 18 -> 19

b03a6a5

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 24, 2026

petrus-v approved these changes Jun 10, 2026

View reviewed changes

AnizR approved these changes Jun 11, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 11, 2026

petrus-v mentioned this pull request Jun 11, 2026

[19.0][MIG] account_cutoff_base: add tests and tanke care review akretion/account-closing#7

Open

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] account_cutoff_base#357

[19.0][MIG] account_cutoff_base#357
alexis-via wants to merge 154 commits into
OCA:19.0from
akretion:19-mig-account_cutoff_base

alexis-via commented Jan 19, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

petrus-v left a comment

Uh oh!

petrus-v Jun 10, 2026

Uh oh!

petrus-v Jun 10, 2026

Uh oh!

AnizR left a comment

Uh oh!

AnizR Jun 11, 2026

Uh oh!

AnizR Jun 11, 2026

Uh oh!

OCA-git-bot commented Jun 11, 2026

Uh oh!

petrus-v commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

alexis-via commented Jan 19, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

petrus-v left a comment

Choose a reason for hiding this comment

Uh oh!

petrus-v Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

petrus-v Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

AnizR left a comment

Choose a reason for hiding this comment

Uh oh!

AnizR Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

AnizR Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jun 11, 2026

Uh oh!

petrus-v commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants