Skip to content

[14.0][ADD] account_budget_oca_analytic_tag#58

Open
cvinh wants to merge 3 commits into
OCA:14.0from
cvinh:14.0-add_account_budget_oca_analytic_tag
Open

[14.0][ADD] account_budget_oca_analytic_tag#58
cvinh wants to merge 3 commits into
OCA:14.0from
cvinh:14.0-add_account_budget_oca_analytic_tag

Conversation

@cvinh

@cvinh cvinh commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Courtesy of @max3903

@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch 2 times, most recently from 2745daf to 52ac7ee Compare October 31, 2022 17:59
@max3903 max3903 added this to the 14.0 milestone Oct 31, 2022
@max3903

max3903 commented Oct 31, 2022

Copy link
Copy Markdown
Member

@cvinh We will want to separate in 2 PRs.

@max3903 max3903 self-assigned this Oct 31, 2022
@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch from 52ac7ee to 3a99d68 Compare October 31, 2022 18:42
@cvinh cvinh changed the title [14.0][ADD] account_budget_oca_analytic_tag + purchase_budget_oca_validation [14.0][ADD] account_budget_oca_analytic_tag Oct 31, 2022
@cvinh

cvinh commented Oct 31, 2022

Copy link
Copy Markdown
Contributor Author

@cvinh We will want to separate in 2 PRs.

Done

@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch 2 times, most recently from 16e99c0 to 3176f01 Compare March 20, 2023 18:27

@rvalyi rvalyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two immediate remarks:

  1. usually this kind of logo is not accepted in the OCA https://github.com/OCA/account-budgeting/pull/58/files#diff-8118393e2174e2ba6b031f266e1e4a8b45697baddc3cd591c01398dc1ccf549e
  2. I think some tests would be required. The current coverage is at 40% while the repo coverage is at 75%

@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch 9 times, most recently from daf9319 to 98a81a7 Compare June 9, 2023 08:05
@cvinh cvinh force-pushed the 14.0-add_account_budget_oca_analytic_tag branch from 98a81a7 to ef1cfff Compare September 19, 2025 06:15
@matias-costa

Copy link
Copy Markdown

Corrección aplicada por fallo en CI - commit 8742276:

  • Problema: en CI el módulo website está instalado, por lo que ir.http._handle_error redirige con 303 a /portal/login para requests anónimas. El assert limitado a [403, 404] fallaba en CI aunque era correcto en local (sin website). El assert vuelve a aceptar [301, 302, 303, 403, 404] con docstring explicando el motivo — el comportamiento varía según si website está instalado en el entorno, y en ambos casos el acceso está correctamente restringido.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants