feat: Add SponsorBlock integration and Dual Subtitles support#1323
Open
Eliaway wants to merge 5 commits into
Open
feat: Add SponsorBlock integration and Dual Subtitles support#1323Eliaway wants to merge 5 commits into
Eliaway wants to merge 5 commits into
Conversation
SponsorBlock: - Full SponsorBlock API integration with privacy-preserving hash-based lookups - Configurable categories (sponsor, selfpromo, interaction, intro, outro, filler, etc.) - Auto-skip and manual skip button modes - Merged with existing IntroDb/AniSkip skip intervals (deduplication via overlap detection) - Per-platform SHA-256 implementations (Android/iOS/Desktop) - Settings UI with category toggles and privacy mode Dual Subtitles: - Cross-platform SRT/WebVTT subtitle parser with binary search for O(log n) cue lookup - Secondary subtitle rendered as Compose overlay (zero interference with native player) - DualSubtitleSelector UI for picking secondary language from addon subtitles - Customizable secondary subtitle style (color, size, position) - Position-synced updates via existing playback snapshot pipeline Modified files: - PlayerScreenRuntimeEffects.kt: SponsorBlock fetch + merge + dual subtitle position updates - PlayerPlaybackOverlays.kt: DualSubtitleOverlay placement - SkipIntroButton.kt: Added SponsorBlock category labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SponsorBlock:
Dual Subtitles:
Modified files:
Summary
PR type
Why
Issue or approval
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Testing
Screenshots / Video (UI changes only)
Breaking changes
Linked issues