i18n(fr): backfill 120 missing translations + extract 7 hardcoded strings (pass 6)#1322
Open
foXaCe wants to merge 1 commit into
Open
i18n(fr): backfill 120 missing translations + extract 7 hardcoded strings (pass 6)#1322foXaCe wants to merge 1 commit into
foXaCe wants to merge 1 commit into
Conversation
…ings (pass 6)
- Backfilled all 120 missing French translations (tutoiement), including
fusion badges, P2P consent, torrent status, subtitle settings, iOS audio
output, desktop navigation and addon logo settings
- 49 translations reused from NuvioTV FR for cross-project consistency
- Extracted 7 hardcoded strings via the LocalizedUiText resourceString pattern:
- subtitle auto-sync errors (no lines found / load failure)
- stream badge import validation (empty URL, scheme check, import limit,
generic failure)
- P2P not available on desktop message
- Fixed gender agreement on badge URL status (Activé/Désactivé -> Active/Inactive)
- String parity 1847/1847, zero missing/orphan/duplicate keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh localization pass on top of current
cmp-rewrite. Backfills all 120 missing French translations (tutoiement) — fusion badges, P2P consent, torrent status, addon subtitle startup modes, subtitle styling, iOS audio output, player preference, desktop navigation, addon logo settings, Continue Watching cache — and extracts 7 hardcoded user-facing strings through the existingLocalizedUiText.resourceStringpattern. 49 translations reused verbatim from NuvioTV FR for cross-project consistency (peers→pairs, seeds→sources, buffered→en mémoire tampon). Supersedes most of #1239 (pass 5), which can be closed once this is merged.PR type
Why
The French file was 120 keys behind English after recent upstream work, and a few user-facing strings (subtitle auto-sync errors, badge import validation, P2P desktop message) were hardcoded in Kotlin and could not be localized. This pass restores full EN↔FR parity.
Issue or approval
No linked issue: localization-only update, same scope as previous localization passes.
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Only the two string resource files and the minimal code changes required to reference the new keys (
LocalizedUiTexthelpers + their call sites). The deadlabel/descriptionString fields onIosVideoOutputPresetwere intentionally not cleaned up (out of scope). TheMPVKitsubmodule pointer is untouched.Testing
./gradlew :composeApp:compileFullDebugKotlinAndroidpasses. Both XML files validated with xmllint. Key parity EN↔FR: 1847/1847, 0 missing, 0 orphan, 0 duplicate keys. Placeholders preserved (%1$d,%1$s). Note::composeApp:compileKotlinDesktopis currently broken oncmp-rewriteitself (missingactualforloadShowAddonLogo()/loadPendingDeviceAuthorization()in desktop stubs) — unrelated to this PR.Screenshots / Video
None - text-only localization change, no UI change.
Breaking changes
None.
Linked issues
No linked issue - localization-only update.