Download subtitles locally before passing to external players#1313
Merged
Conversation
tapframe
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port subtitle caching for external players from NuvioTV (commit 49182691). Instead of passing raw addon subtitle URLs to external players, subtitles are now downloaded to local cache and shared via content:// URIs through FileProvider. Also adds
buildPlayerTitle()for structured episode titles and subtitle forwarding to Infuse/VLC on iOS.PR type
Why
Alignment with functionality already shipping in the TV version. Some external players often cannot access addon subtitle URLs directly. The TV app already solves this by downloading subtitles to a local cache and passing content:// URIs. This PR brings the same fix to mobile.
Issue or approval
No linked issue - feature parity port from NuvioTV commit 49182691ae1f857b9bcc70629f8d6e56538bb934.
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Testing
compileFullDebugKotlinAndroidsubtitles/cache directoryScreenshots / Video (UI changes only)
Not a UI change.
Breaking changes
None.
Linked issues
No linked issue - feature parity port from NuvioTV commit 49182691.