feat(ios): add native PiP and Now Playing integration#1269
Open
WhiteGiso wants to merge 1 commit into
Open
Conversation
5315b80 to
db402ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native iOS Picture in Picture support for the existing MPV-based player bridge and integrates system
Now Playing/ remote playback controls so playback state is reflected correctly in Control Center and lock screen.PR type
Why
This change brings the iOS player closer to the expected native media experience:
Now PlayingIssue or approval
Approved in
#1268.UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
Not changed in this PR:
MPVKit/local/untracked filesproject.pbxprojlocal environment changesTesting
Manual testing on iOS device:
Now Playingappears in Control Center / lock screenScreenshots / Video
Not a UI change.
Breaking changes
None.
Linked issues
Fixes
#1268