Auto-play next episode for external players#1266
Open
Laskco wants to merge 1 commit into
Open
Conversation
Mobile had no auto-next path for external players (only the internal player advanced episodes). This wires the same next-episode flow for external playback. - Detect completion from the external player result (end_by, with a 90% position fallback for players that don't report a reason) - Resolve the next episode via MetaDetails.nextReleasedEpisodeAfter and route it through the normal episode-play path, reusing the existing stream auto-play -> external relaunch flow, gated by the existing "Auto-play next episode" setting - Persist the launch snapshot to disk so auto-next survives the external player killing the app process (observed on NVIDIA Shield); recover it when the result is redelivered to the recreated process - Show a "Loading next episode" loader covering the cold-start / source-resolution hand-off
Author
8mb.video-xT0-yCsOkMrh.mp4Video showing that auto-next is working with external players. (Sorry about the quality github only allows 10mb uploads) @skoruppa Added external player auto-next to the mobile version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds auto-play next episode support for external players. The internal player already advances to the next episode when one finishes, but external players (mpv, Vimu, MX Player, VLC, etc.) had no equivalent path, so auto-next was unavailable for anyone using one. Routes external playback through the same next-episode flow the internal player uses, gated by the existing "Auto-play next episode" setting (no new toggle).
PR type
Why
External playback (
App.kt'srememberExternalPlayerLauncherresult handler) only saved progress and stopped, it never resolved a next episode or re-entered the play flow, so binge/auto-next did not work with an external player. This brings external playback to parity with the internal player. Maintainer-requested as the mobile counterpart to the same feature approved for NuvioTV.Issue or approval
Maintainer-requested mobile parity for the external auto-next feature approved for NuvioTV (NuvioMedia/NuvioTV#2190, implemented in NuvioMedia/NuvioTV#2198).
UI / behavior impact
Policy check
CONTRIBUTING.md.Scope boundaries
MetaDetails.nextReleasedEpisodeAfter, no change to that logic.Testing
assembleFullDebugAPK, sideloaded.end_by=user).end_by=playback_completionand the 90% position fallback.Screenshots / Video (UI changes only)
The only UI is a full-screen "Loading next episode" loader shown during the hand-off. Screen recording to be attached.
Breaking changes
None.
Linked issues
NuvioMedia/NuvioTV#2190 (approved feature).