Upgrade inventory UX + input-guard bug fixes#108
Merged
Conversation
guard /users/:id and /users/inventory/:userId against non-ObjectId ids (the 'Cast to ObjectId failed' 500s), validate caseId and escape the inventory name search so malformed filters can't throw, and reject password login for accounts with no password (Google sign-ins) instead of letting bcrypt throw 'Illegal arguments'. covered by integration tests.
default to newest-first, add a debounced name search and a rarity filter alongside the sort options, reset to page 1 whenever a filter changes, and show the total page count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (the two prod error-log lines):
Upgrade inventory UX:
Integration tests added for the guards.