Skip to content

feat(TTS): Skip page-breaks option#168

Merged
ddfreiling merged 11 commits into
mainfrom
wip/pagebreaking
Jun 30, 2026
Merged

feat(TTS): Skip page-breaks option#168
ddfreiling merged 11 commits into
mainfrom
wip/pagebreaking

Conversation

@m-abs

@m-abs m-abs commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator
  • WIP: wrap html resource iterator
  • feat(TTS): Skip page breaks
  • start iOS skip page number TTS

@m-abs m-abs requested a review from ddfreiling June 29, 2026 07:56
@m-abs m-abs changed the title feat(TTS): Skip page-breaks option" feat(TTS): Skip page-breaks option Jun 29, 2026
@m-abs

m-abs commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

I just ran the iOS integration tests on my iPhone without an issue, I'm not sure why this failed.

@ddfreiling

ddfreiling commented Jun 29, 2026

Copy link
Copy Markdown
Member

I just ran the iOS integration tests on my iPhone without an issue, I'm not sure why this failed.

The failure is real for the PDF search test, as we now inject a HTMLResourceContentIterator no matter the publication type - in this PR.

@m-abs m-abs marked this pull request as ready for review June 30, 2026 09:54

@ddfreiling ddfreiling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on iOS

@ddfreiling ddfreiling merged commit dd02231 into main Jun 30, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants