Added signed int support to bitstream#290
Merged
Merged
Conversation
bjackson312006
force-pushed
the
feature/bitstream-signed
branch
from
124a966 to
41babae
Compare
bjackson312006
force-pushed
the
feature/bitstream-signed
branch
from
41babae to
4929163
Compare
jr1221
approved these changes
May 25, 2025
| result |= (1 << (num_bits - 1 - i)); | ||
| if (unsigned_value & (1u << (num_bits - 1 - i))) { | ||
| bitstream->data[(bitstream->total_bits + i) / 8] |= | ||
| (1 << (7 - ((bitstream->total_bits + i) % 8))); |
Contributor
There was a problem hiding this comment.
how does this code handle the leftmost signed bit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added signed int support to bitstream.c using _Generic. bitstream_add() is a macro now, but everything should still work the same. I also removed bitstream_read() since it's not really useful and would probably just be confusing now that bitstream also supports signed ints.
Notes
Not tested yet
Checklist