Modified u_ethernet.c and related files based on review suggestions.#16
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses review feedback by replacing hardcoded values and TODO comments with proper configuration constants, improving code maintainability and removing temporary placeholders.
- Replaced hardcoded PLCA node configuration values with named constants
- Updated queue operations to use configurable wait times instead of no-wait behavior
- Added time conversion macros and configuration constants
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| NetXDuo/Target/nx_stm32_phy_custom_driver.c | Updated PLCA configuration to use constants instead of hardcoded values |
| Core/Src/u_queues.c | Changed queue operations from no-wait to configurable timeout |
| Core/Src/u_ethernet.c | Fixed inconsistent constant usage in UDP socket receive |
| Core/Inc/u_queues.h | Added queue wait time configuration constant |
| Core/Inc/u_ethernet.h | Added network node count constant and removed TODO comment |
| Core/Inc/u_config.h | Added time conversion utility macros |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.