Repository navigation
chore: make lint-and-typecheck green (biome + TS7 typecheck) - #3
Merged
Merged
Conversation
The PR gate never passed (PR #1 was the repo's first), so both steps had pre-existing debt unrelated to any feature change. biome: - biome format across the repo (formatting + organizeImports), 45 files - ignore the generated apps/docs/public/openapi.json (exceeds size rule) - relax style/complexity nits for apps/docs/scripts/** (codegen; delete is intentional) typecheck (under the repo's TypeScript 7.0.2 native compiler + React 19): - bump framer-motion 11.3.19 -> 14.2.0 (its motion types resolve under TS7/React 19; same import path and APIs) — clears 11 motion className errors - useRef(undefined) / RefObject<Element> cast for React 19 (use-debounce, number-ticker) - type getTags/getPostsByTag returns in lib/ghost.ts (no more unknown in blog pages) - blog code renderer: drop the removed react-markdown inline prop; coerce img src - OG route: wrap Buffer in Uint8Array (valid BodyInit) - ContactFormModal: map the extra 'other' inquiry type to '' for ContactForm Both `pnpm biome ci` and `pnpm typecheck` pass locally.
CI ran Node 18.18.0 while the repo requires node ^24.4.0 (and the Dockerfiles already build on node:24.4). On Node 18 the typecheck step crashed launching TypeScript 7.0.2's extensionless bin (ERR_UNKNOWN_FILE_EXTENSION). Point the workflow at .nvmrc and bump .nvmrc to 24.4.0 so CI matches the actual runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint-and-typecheckPR gate never actually passed (PR #1 was the repo's first), so both of its steps carried pre-existing debt unrelated to any feature change. This makes the gate green so it starts protecting future PRs.pnpm biome ciapps/docs/public/openapi.json(exceeds biome's size rule).apps/docs/scripts/**(codegen helpers;deleteon the OpenAPI spec is intentional).pnpm typecheck(repo runs TypeScript 7.0.2 + React 19)11.3.19→14.2.0— itsmotiontypes don't resolve under TS7/React 19; the new line does, with the sameframer-motionimport path and APIs (motion.*, AnimatePresence, useInView, useMotionValue, useSpring). Clears 11motion … classNameerrors.useRef(undefined)(use-debounce),RefObject<Element>cast (number-ticker).getTags/getPostsByTagreturns inlib/ghost.ts(blog pages no longer seeunknown).inlineprop; coerceimgsrc to string.BufferinUint8Array(validBodyInit)."other"inquiry type to""forContactForm.Both
pnpm biome ciandpnpm typecheckpass locally. Most of the diff is formatting; the logic changes are confined to the files listed above plusbiome.json/package.json/ lockfile.