remote-store: do not forward use-xdg-base-directories#16045
Open
filaka771 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
with-tests
Author
|
Hi @YoshiRulz, I opened this PR to fix the issue you reported. I’d really appreciate your review when you have time. Hi @lisanna-dettwyler, since you participated in the issue discussion and suggested a possible approach for the fix, I’d also appreciate your feedback when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #15988.
When passing --option use-xdg-base-directories to certain nix-env subcommands like --install, a warning is erroneously printed.
According to the
nix-daemondocumentation, the purpose of the daemon is to run builds and other operations on behalf of unprivileged users. Therefore, it is weird to forwarduse-xdg-base-directoriesoption.The image below shows that the warning is reproduced, while the expected XDG profile symlinks are still created:
The fix removes
settings.useXDGBaseDirectories.namefrom the forwarded override set.The image below shows that after the fix warning no longer appears, while expected XDG profile symlinks are still created:
Context