PIGS-642: Fix MCP server reporting version as 0.0.0-dev in initialize response#51
Closed
IvanK-Nitro wants to merge 2 commits into
Closed
PIGS-642: Fix MCP server reporting version as 0.0.0-dev in initialize response#51IvanK-Nitro wants to merge 2 commits into
IvanK-Nitro wants to merge 2 commits into
Conversation
Add --define:process.env.MCP_SERVER_VERSION to the esbuild invocation in the build task so the version from manifest.json is baked into dist/bundle.cjs at compile time, replacing the 0.0.0-dev fallback in the initialize response.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Contributor
Author
|
This is not urgent, whenever you have time |
RogerThomas
approved these changes
Apr 29, 2026
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildtask innode-version/Taskfile.ymlnow runs esbuild directly with--define:process.env.MCP_SERVER_VERSION="{{.VERSION}}", baking the version frommanifest.jsoninto the bundle at compile timetask bundle(vianpm run bundle) which called esbuild without the--defineflag, soprocess.env.MCP_SERVER_VERSIONwas alwaysundefinedat runtime and fell back to0.0.0-devmanifest.jsonin this task (to name the output.mcpbfile), so no new logic was needed — just passing it one step earlier into esbuildTest plan
task buildand confirm the produced bundle reports the correct version in the MCPinitializeresponsetask bundlestandalone and confirm it still works (unchanged behaviour)Fixes PIGS-642
🤖 Generated with Claude Code