Skip to content

bio: left-align all right-pane headings and content#471

Open
Copilot wants to merge 4 commits into
mainfrom
copilot/left-align-bio-page-content
Open

bio: left-align all right-pane headings and content#471
Copilot wants to merge 4 commits into
mainfrom
copilot/left-align-bio-page-content

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 2, 2026

  • Review PR bio: left-align all right-pane headings and content #471 feedback and identify requested updates
  • Run existing project build before changes to verify baseline
  • Update bio right-pane section heading size from text-xs to text-sm for all three sections
  • Re-run build to validate changes
  • Run PR validation checks and address any findings

@jbampton jbampton marked this pull request as ready for review May 2, 2026 22:53
@jbampton jbampton requested review from BaseMax and jbampton as code owners May 2, 2026 22:53
@jbampton jbampton added this to the Turbo milestone May 2, 2026
@jbampton jbampton moved this to Review in progress in Next May 2, 2026
@jbampton jbampton requested a review from Copilot May 2, 2026 22:53
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bio page’s right-pane card headings to be flush-left by removing the decorative leading rule and the flex layout that caused visual indentation.

Changes:

  • Removed the decorative <span> line from the “Professional Bio”, “Technologies”, and “Mini-Game” right-pane headings.
  • Dropped flex items-center gap-2 from those headings so heading text aligns with the card content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the section headings in src/_includes/bio.njk by removing decorative accent lines and their associated layout classes. The review feedback suggests increasing the heading font size from text-xs to text-sm to resolve an inverted visual hierarchy where headings appear smaller than the body text, and also recommends consolidating these repeated styles into a shared utility.

Comment thread src/_includes/bio.njk Outdated
Comment thread src/_includes/bio.njk Outdated
Comment thread src/_includes/bio.njk Outdated
@jbampton jbampton requested a review from Copilot May 11, 2026 12:27
@jbampton
Copy link
Copy Markdown
Member

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/_includes/bio.njk
Comment on lines +79 to 81
<h2 class="text-sm font-black uppercase tracking-[0.3em] text-[var(--text-muted)] mb-6">
Professional Bio
</h2>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the section headings in src/_includes/bio.njk by increasing the font size and removing decorative accent lines to achieve a cleaner, left-aligned layout. The reviewer suggests placing the heading text on the same line as the tags to prevent potential whitespace rendering issues that can occur with the large letter-spacing applied to these elements.

Comment thread src/_includes/bio.njk
Comment thread src/_includes/bio.njk
Comment thread src/_includes/bio.njk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in progress

Development

Successfully merging this pull request may close these issues.

3 participants