Add and fix some typings#85
Merged
Merged
Conversation
Owner
|
Thanks for the PR. Could you resolve the merge conflicts? |
Contributor
Author
|
Done! If you're amenable, I would also like to start some work on tests and then some file sorting improvements. I don't know if you remember, but I started similar work a couple years ago. The codebase changed enough that I closed that PR request but I think it would be a big improvement for the import process. |
Neurrone
requested changes
Apr 13, 2026
Owner
|
Having more tests would be really useful. I tried adding tests but the current plugin isn't really set up well for that. Ideally, it should be possible to have lists of results from Audible, metadata from a book to be imported and we can check that the plugin assigns the correct Audible result. |
Contributor
Author
|
I'll attempt it then once this is merged! |
Neurrone
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes to the typings for some functions, mainly adding some but also fixing a couple incorrect typings.