Unify module layer resolution - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configurations.ResolutionMotivation
A linked self-hosting runtime could expose both
jrt:and source versions of the same module in the reachable graph. Callers independently reduced that graph by module name, so selection depended on set iteration order. This changed test cache identities between runs. Other tool resolution code also bypassed the resolved graph by looking modules up again on the module path.The resolution object now owns:
All production
Configuration.resolve/resolveAndBind,ResolvedModule.reads(), andModuleLayer.defineModulesWithOneLoaderuse in the application module now lives inConfigurations.Validation
ja run -m com.netflix.tools.ja test --all— 385/385 successful