Avoid duplicate schema source readers - #968
Merged
Merged
Conversation
iuliiasobolevska
requested review from
asibross,
iparadiso,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
September 23, 2026 16:59
jiholee17
approved these changes
Sep 23, 2026
iuliiasobolevska
force-pushed
the
fix/avoid-duplicate-schema-readers
branch
from
September 23, 2026 19:55
154d285 to
939e671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeGeninstanceCodeGen(CodeGenConfig)interface while exposing an internal synthetic test seamBenchmark
A successful 2,001-file schema workload was run in seven alternating fresh JVMs against
masterand this branch using the installed CLI distribution. Median wall time improved from 0.55 s to 0.50 s (about 9%). The lifecycle regression test verifies the stronger invariant directly: one filesystem reader open/close per schema on success.Verification
./gradlew :graphql-dgs-codegen-core:test :graphql-dgs-codegen-core:integrationTest :graphql-dgs-codegen-core:lintKotlinCodeGenTesttests pass; no module failuresCodeGen(CodeGenConfig)andgenerate()unchanged