Improve Docker build security and efficiency for frontend#579
Merged
Conversation
…tainer Without --chown=node:node on COPY instructions, Docker copies files as root even under USER node, causing node_modules/.vite writes to fail at runtime. Added .dockerignore to prevent host node_modules from overwriting the npm ci result inside the image. https://claude.ai/code/session_012GkEL9VGqN4tT4uFJuEjq1
Config was at .github/.hadolint.yaml but workflow referenced .github/workflows/.hadolint.yaml causing hadolint to fail. https://claude.ai/code/session_012GkEL9VGqN4tT4uFJuEjq1
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Docker build configuration for the frontend application by implementing proper file ownership handling and adding a
.dockerignorefile to optimize build context.Key Changes
--chown=node:nodeflag to allCOPYinstructions in both development and production build stages. This ensures files are owned by thenodeuser rather thanroot, improving security and consistency with theUSER nodedirective..dockerignorefile: Created a.dockerignorefile to exclude unnecessary files and directories (node_modules,.vite,dist,.git,*.md) from the Docker build context, reducing build time and image size.Implementation Details
--chownflag is applied to both package dependency files and application source code copies.dockerignoreexclusions prevent redundant copying of build artifacts, dependencies, and documentation that don't need to be in the containerhttps://claude.ai/code/session_012GkEL9VGqN4tT4uFJuEjq1