feat(print): add ability to print pdf on Windows - #127
Merged
Merged
Conversation
SRWieZ
approved these changes
Sep 2, 2026
gwleuverink
pushed a commit
that referenced
this pull request
Sep 14, 2026
PR #127 added src/server/pdfPageSize.ts and updated dist/server/api/system.js to import '../pdfPageSize.js', but the new compiled dist/server/pdfPageSize.js was never force-added (dist/ is gitignored, all other dist/*.js files are tracked via `git add -f`). As a result, 2.3.0 ships an unresolvable import and `electron-vite` fails to produce out/main/index.js, so `native:run` cannot start. Refs #152 Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to print on Windows by adding a new
printFilefunction, which is using Chromium's built-in PDF viewer.Also solves #103.