Skip to content

Production deploy#1556

Merged
russellcullen merged 4 commits into
productionfrom
qa
Dec 15, 2025
Merged

Production deploy#1556
russellcullen merged 4 commits into
productionfrom
qa

Conversation

@russellcullen

Copy link
Copy Markdown
Contributor

Two main changes in this release:

  • Remove Adobe Analytics
  • Add December 2025 school

@Toxiapo Toxiapo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,2 @@
LOCATION_CODE,LOCATION_NAME,PRIMARY_ADDRESS_LINE_1,STATE_CODE,PRINCIPAL_PHONE_NUMBER,Location 1
Q841,P.S. Q023 @ 841,48-25 37 Street,NY,(718) 610-3154,Queens 11101 No newline at end of file

@Toxiapo Toxiapo Dec 15, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these line breaks cause problems?

@russellcullen russellcullen Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the script locally and in QA without problem -- so I don't think so. It's a good question though, Im actually not quite sure if the csv "spec" cares about ending newlines, maybe it just comes down to how parsing is implemented in the ruby script 🤷

@russellcullen russellcullen merged commit efe0888 into production Dec 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants