fix: anchor MIG resource pattern matching#1807
Open
raglin wants to merge 2 commits into
Open
Conversation
raglin
force-pushed
the
fix/mig-pattern-anchoring
branch
from
72430be to
723d36e
Compare
|
@tariq1890 / @cdesiniotis will you be able to review this ? |
Contributor
|
Thank you @raglin for your patience. Let's address the following:
|
raglin
changed the title
raglin
force-pushed
the
fix/mig-pattern-anchoring
branch
2 times, most recently
from
cc35b3b to
5ea63b4
Compare
The wildCardToRegexp function did not anchor patterns with ^ and $, causing patterns like '1g.24gb' to match '1g.24gb-me' via substring. This prevented the mixed MIG strategy from distinguishing profiles with suffixes (-me, +me.all, +gfx) as separate Kubernetes resources. Signed-off-by: Raglin Anthony <raglinanthony@gmail.com>
raglin
force-pushed
the
fix/mig-pattern-anchoring
branch
from
cd6c91b to
2942197
Compare
Author
|
Thanks for the feedback @tariq1890 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wildCardToRegexp function did not anchor patterns with ^ and $, causing patterns like '1g.24gb' to match '1g.24gb-me' via substring. This prevented the mixed MIG strategy from distinguishing profiles with suffixes (-me, +me.all, +gfx) as separate Kubernetes resources
Fixes #1462