Skip to content

fix(ssh-console): fall back for Lenovo SOL activation#2943

Draft
williampnvidia wants to merge 1 commit into
NVIDIA:mainfrom
williampnvidia:william/lenovo-sr650-v4-sol-fallback
Draft

fix(ssh-console): fall back for Lenovo SOL activation#2943
williampnvidia wants to merge 1 commit into
NVIDIA:mainfrom
williampnvidia:william/lenovo-sr650-v4-sol-fallback

Conversation

@williampnvidia

Copy link
Copy Markdown
Contributor

Summary

  • keep the existing Lenovo SOL activation command as the primary path
  • detect the SR650 v4 Lenovo extraneous arguments response and fall back to console kill / console start
  • add focused unit tests for the Lenovo fallback decision and existing non-Lenovo activation behavior

Fixes #2919

Test plan

  • cargo +nightly-2026-06-16 fmt --all -- --check
  • git diff --check fork/main..HEAD
  • cargo test -p carbide-ssh-console --lib lenovo_primary_failure
  • cargo test -p carbide-ssh-console --lib non_lenovo_activation
  • cargo test -p carbide-ssh-console --lib

Note: William ran the cargo tests on Linux. Local macOS test execution is blocked by existing Linux-specific io_util.rs termios compile errors.

@copy-pr-bot

copy-pr-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7ec3a41b-4b78-4850-95a0-03b02f394fd7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@williampnvidia williampnvidia force-pushed the william/lenovo-sr650-v4-sol-fallback branch from c208254 to a0fbbbd Compare June 27, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssh-console: fall back to SR650 v4 Lenovo SOL command sequence

1 participant