Skip to content

fix(scout): tolerate a dead NVMe during cleanup (do not fail the whole machine) #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirson-git wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(scout): tolerate a dead NVMe during cleanup (do not fail the whole machine) #2914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/scout/src/deprovision/scrabbing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 +498,16 @@ async fn all_nvme_cleanup() -> Result<(), CarbideClientError> {
"NVMe cleanup completed"
);

if !errors.is_empty() && success_count == 0 {
return Err(CarbideClientError::GenericError(format!(
"all NVMe device(s) failed cleanup:\n{}",
errors.join("\n")
)));
}
if !errors.is_empty() {
return Err(CarbideClientError::GenericError(errors.join("\n")));
// a dead/failed drive must not fail the whole machine; the OS install targets a
// healthy drive. Extends the per-format tolerance from #2820 to the cleanup result.
tracing::warn!(success_count, failed = errors.len(), "some NVMe devices failed cleanup but at least one succeeded; continuing");
}

Ok(())
Expand Down