-
Notifications
You must be signed in to change notification settings - Fork 135
feat: per-machine BMC vendor override #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
s3rj1k
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
s3rj1k:feat/machine-bmc-vendor-override
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| use carbide_uuid::machine::MachineId; | ||
| use clap::Parser; | ||
|
|
||
| #[derive(Parser, Debug, Clone)] | ||
| pub enum Args { | ||
| #[clap(about = "Pin the Redfish BMC vendor for a machine")] | ||
| Set(VendorOverrideSet), | ||
| #[clap(about = "Clear the Redfish BMC vendor override for a machine")] | ||
| Clear(VendorOverrideClear), | ||
| #[clap(about = "Show the Redfish BMC vendor override for a machine")] | ||
| Show(VendorOverrideShow), | ||
| } | ||
|
|
||
| #[derive(Parser, Debug, Clone)] | ||
| #[command(after_long_help = "\ | ||
| EXAMPLES: | ||
|
|
||
| Force a machine's BMC vendor to Dell: | ||
| $ nico-admin-cli machine vendor-override set 12345678-1234-5678-90ab-cdef01234567 \ | ||
| --vendor Dell | ||
|
|
||
| ")] | ||
| pub struct VendorOverrideSet { | ||
| #[clap(help = "The machine whose BMC vendor should be pinned")] | ||
| pub machine: MachineId, | ||
| #[clap( | ||
| long, | ||
| help = "RedfishVendor to force (e.g. Dell, Supermicro, NvidiaDpu, Hpe, Lenovo)" | ||
| )] | ||
| pub vendor: String, | ||
| } | ||
|
|
||
| #[derive(Parser, Debug, Clone)] | ||
| #[command(after_long_help = "\ | ||
| EXAMPLES: | ||
|
|
||
| Clear a machine's BMC vendor override (return to automatic detection): | ||
| $ nico-admin-cli machine vendor-override clear 12345678-1234-5678-90ab-cdef01234567 | ||
|
|
||
| ")] | ||
| pub struct VendorOverrideClear { | ||
| #[clap(help = "The machine whose BMC vendor override should be cleared")] | ||
| pub machine: MachineId, | ||
| } | ||
|
|
||
| #[derive(Parser, Debug, Clone)] | ||
| #[command(after_long_help = "\ | ||
| EXAMPLES: | ||
|
|
||
| Show a machine's pinned BMC vendor (or that none is set): | ||
| $ nico-admin-cli machine vendor-override show 12345678-1234-5678-90ab-cdef01234567 | ||
|
|
||
| ")] | ||
| pub struct VendorOverrideShow { | ||
| #[clap(help = "The machine whose BMC vendor override should be shown")] | ||
| pub machine: MachineId, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| use carbide_uuid::machine::MachineId; | ||
| use rpc::Machine; | ||
|
|
||
| use super::args::{Args, VendorOverrideClear, VendorOverrideSet, VendorOverrideShow}; | ||
| use crate::errors::{CarbideCliError, CarbideCliResult}; | ||
| use crate::rpc::ApiClient; | ||
|
|
||
| pub async fn vendor_override(api_client: &ApiClient, cmd: Args) -> CarbideCliResult<()> { | ||
| match cmd { | ||
| Args::Set(cmd) => set(api_client, cmd).await, | ||
| Args::Clear(cmd) => clear(api_client, cmd).await, | ||
| Args::Show(cmd) => show(api_client, cmd).await, | ||
| } | ||
| } | ||
|
|
||
| async fn fetch_machine(api_client: &ApiClient, machine_id: MachineId) -> CarbideCliResult<Machine> { | ||
| let mut machines = api_client | ||
| .get_machines_by_ids(&[machine_id]) | ||
| .await? | ||
| .machines; | ||
| machines.pop().ok_or_else(|| { | ||
| CarbideCliError::GenericError(format!("Machine with ID {machine_id} was not found")) | ||
| }) | ||
| } | ||
|
|
||
| async fn set(api_client: &ApiClient, cmd: VendorOverrideSet) -> CarbideCliResult<()> { | ||
| api_client | ||
| .update_machine_bmc_vendor_override(cmd.machine, Some(cmd.vendor)) | ||
| .await | ||
| } | ||
|
|
||
| async fn clear(api_client: &ApiClient, cmd: VendorOverrideClear) -> CarbideCliResult<()> { | ||
| api_client | ||
| .update_machine_bmc_vendor_override(cmd.machine, None) | ||
| .await | ||
| } | ||
|
|
||
| async fn show(api_client: &ApiClient, cmd: VendorOverrideShow) -> CarbideCliResult<()> { | ||
| let machine = fetch_machine(api_client, cmd.machine).await?; | ||
| match machine.bmc_vendor_override.as_deref() { | ||
| Some(vendor) => println!("{vendor}"), | ||
| None => println!("not set (automatic detection)"), | ||
| } | ||
| Ok(()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| pub mod args; | ||
| pub mod cmd; | ||
|
|
||
| pub use args::Args; | ||
|
|
||
| use crate::cfg::run::Run; | ||
| use crate::cfg::runtime::RuntimeContext; | ||
| use crate::errors::CarbideCliResult; | ||
|
|
||
| impl Run for Args { | ||
| async fn run(self, ctx: &mut RuntimeContext) -> CarbideCliResult<()> { | ||
| cmd::vendor_override(&ctx.api_client, self).await?; | ||
| Ok(()) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
crates/api-db/migrations/20260625120000_machine_bmc_vendor_override.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| -- Add bmc_vendor_override to machines so an operator can pin the Redfish BMC | ||
| -- vendor for a machine. NULL means automatic detection. The value is a | ||
| -- RedfishVendor variant name passed down into libredfish as the forced vendor. | ||
| ALTER TABLE machines ADD COLUMN bmc_vendor_override text; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.