chore(core): cover key state controller keyboard branches - #344
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/elements/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/vitestThe overall line coverage in commit ce2cce3 in the Show a line coverage summary of the most impacted files.
Updated |
Adds unit tests for the enabled getter, repeated keydown, unheld keyup, visible document changes, empty blur, and blur updates limited to hosts watching the cleared key. Line coverage rises from 98.41% (62/63) to 100% (63/63), and branch coverage rises from 81.25% (26/32) to 96.87% (31/32). No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
7c4d229 to
ce2cce3
Compare
|
🎉 This issue has been resolved in version 2.7.1 🎉 |
|
🎉 This issue has been resolved in version 2.2.7 🎉 |
|
🎉 This issue has been resolved in version 2.10.0 🎉 |
2 participants
Selected task: coverage for
projects/core/src/internal/controllers/key-state.controller.ts.Selector rationale: "1 uncovered lines, 98.41% lines and 81.25% branches, the smallest gap below the 90% threshold".
Before and after, from
projects/coreunit coverage:No other file's coverage decreased. No public API changed. Production code is untouched.
Left alone: the duplicate-subscribe return in
DocumentKeyStateSource.subscribe. The controller subscribes a host only after leaving the previous source, so that branch is not reachable through the public controller surface.Validation:
projects/corelint, test, test:coverage (2197 tests), test:types, test:axe, test:ssr, test:lighthouse, and test:visual passed. Rootpnpm run cipassed.git diff --checkpassed.