chore(core): cover default spatial keynav constructor options - #341
Merged
Merged
Conversation
Adds a unit test for constructing KeyNavigationSpatialController without options, covering the default isEnabled path. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/elements/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Sep 24, 2026
coryrylan
deleted the
topic/upkeep/coverage/keynav-spatial-controller
branch
September 24, 2026 23:14
Collaborator
|
🎉 This issue has been resolved in version 2.2.6 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Coverage for
projects/core/src/internal/controllers/keynav-spatial.controller.ts.Selector rationale: "1 uncovered lines, 94.44% lines and 87.5% branches, the smallest gap below the 90% threshold".
Measurement
The gap was the constructor default
isEnabled = () => truewhen options are omitted. The new test constructsKeyNavigationSpatialControllerwith only a host and asserts anArrowRightnve-keycommand.Public API
No public API changed. Production source is unchanged. One existing test file gained 20 lines.
Left alone
keynav-spatial.controller.tsValidation
projects/corelint: passprojects/coreunit tests: 2193 pass (includes the new case)projects/coretest:coverage: pass, target file 100% lines/branchesprojects/coretest:axe: pass (wireit cache after pre-edit CI)projects/coretest:ssr: pass (wireit cache after pre-edit CI)projects/coretest:lighthouse: 79 passprojects/coretest:visual: pass (wireit cache after LFS-recovered CI)projects/coretest:types: pass (wireit cache; no production type changes)pnpm run ci: passgit diff --check: pass