Repository navigation
Conversation
Signed-off-by: midagedev <midagedev@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I hit this while working on bloomery, an LLM inference engine with 67
#[unroll]sites. A const-generic prefill kernel printed "the loop was not unrolled" with no position. hhdri reported the same on #1346: finding three such loops in one kernel meant converting them one at a time. This adds the#[unroll]attribute's position to each warning.Changes
cuda-macros: the__unroll_configmarker takes the#[unroll]attribute's span, not the#[kernel]span. The const-eval error for a bad factor now points at the attribute too (policy_config_invalid_unroll.stderr).mir-transforms: each not-unrolled warning adds--> file:line:colfrom the hint op. The first line is unchanged. With no position, nothing is added. One helper now unlinks a loop's hints and returns the position.gotothat replaces the marker also takes the#[unroll]line.Testing
On Linux (RTX 3090 / A6000), the
just checksteps run by hand:test,test-cudaandcargo docpass, rebased one84e5b3d(Pliron 0.19.0).cargo oxide run unroll_smoke: PASS. Its PTX is byte-identical to main.launch_attrs.rs((1, 0)instead of(2, 4)). The warning test fails on a variant that drops the column.I used Claude Code and a GLM agent to write this patch. I reviewed and ran it.
Checklist
git commit -s)