Synchronize distributed remote downloads#65
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download_file()calls across distributed ranks before returning the resolved pathWhy
download_file()only fetched on rank 0, but the other ranks returned the target path immediately. In multi-GPU inference that lets non-rank0 code race ahead and try to open the file before rank 0 finishes wiring up the symlink and metadata.I used
broadcast_object_list()instead of a plain barrier so the same rendezvous also carries any rank-0 download error to the other ranks, which avoids turning an early rank-0 failure into a later hang or a confusing per-rank file error.Validation
uvx ruff check /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/inference/common/args.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/inference/common/download_file_sync_test.pyuvx ruff format --check /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/inference/common/args.py /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/inference/common/download_file_sync_test.pyPYTHONPATH=/Users/hoangvu/Code/OSS/cosmos-framework uvx pytest --noconftest /Users/hoangvu/Code/OSS/cosmos-framework/cosmos_framework/inference/common/download_file_sync_test.py -o addopts=