Skip to content

Fix agentgateway release pin#1476

Draft
danehans wants to merge 2 commits into
NVIDIA:mainfrom
danehans:fix-agentgateway-release-pin
Draft

Fix agentgateway release pin#1476
danehans wants to merge 2 commits into
NVIDIA:mainfrom
danehans:fix-agentgateway-release-pin

Conversation

@danehans

Copy link
Copy Markdown

Summary

Pin agentgateway and agentgateway-crds to the published agentgateway v1.3.1 release and refresh the generated BOM docs.

Motivation / Context

v2.2.1 is not an agentgateway release, so inference recipes were pointing at an invalid upstream chart version.

Fixes: #1467
Related: N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/aicr, pkg/cli)
  • API server (cmd/aicrd, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Implementation Notes

The agentgateway CRD health check now also asserts the chart-installed agentgateway.dev CRDs are established.

Testing

make bom-docs
make qualify

Also deployed a focused agentgateway bundle to a fresh Kind cluster and verified the controller, inference gateway, Gateway status, service source ranges, and live Chainsaw health checks.

Risk Assessment

  • Low — Isolated chart pin correction, validated with template checks and live Kind deployment
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes: N/A

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S) — GPG signing info

Pin agentgateway charts to v1.3.1 and extend the CRD health check to cover the chart-owned CRDs.

Fixes: NVIDIA#1467
@copy-pr-bot

copy-pr-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

Welcome to AICR, @danehans! Thanks for your first pull request.

Before review, please ensure:

  • All commits are signed off per the DCO
  • CI checks pass (tests, lint, security scan)
  • The PR description explains the why behind your changes

A maintainer will review this soon.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 200bd248-631c-4056-a4fb-46bd3b42b3ab

📥 Commits

Reviewing files that changed from the base of the PR and between caa2fe1 and 1192ddb.

📒 Files selected for processing (1)
  • recipes/mixins/platform-inference.yaml

📝 Walkthrough

Walkthrough

The PR updates agentgateway and agentgateway-crds version references from v2.2.1 to v1.3.1 in the registry, mixin, docs, and an assertion comment. It also rewrites the agentgateway-crds health-check comment and adds a Chainsaw step that checks three agentgateway.dev CRDs are Established=True.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested labels

theme/validation

Suggested reviewers

  • mchmarny
  • njhensley
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: correcting the agentgateway release pin.
Description check ✅ Passed The description is directly related to the version-pin fix and the doc/test updates in this PR.
Linked Issues check ✅ Passed The PR updates the requested agentgateway and agentgateway-crds pins from v2.2.1 to v1.3.1 in the targeted recipe files.
Out of Scope Changes check ✅ Passed The docs refresh and CRD health-check assertion are still aligned with the release-pin correction and appear in scope.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Recipe evidence check

Registry change: scoped to recipes that reference a changed component
entry in recipes/registry.yaml (not every leaf).

Other affected recipes without evidence yet: 26

These recipes are affected by this PR but carry no committed evidence pointer, so there is
nothing to verify. This is expected — evidence is hardware-gated and added over time.

  • b200-gke-cos-inference-dynamo
  • b200-gke-cos-inference
  • gb200-eks-inference
  • gb200-eks-ubuntu-inference-dynamo
  • gb200-eks-ubuntu-inference
  • gb200-oke-inference
  • gb200-oke-ubuntu-inference-dynamo
  • gb200-oke-ubuntu-inference
  • h100-aks-inference
  • h100-aks-ubuntu-inference-dynamo
  • h100-aks-ubuntu-inference
  • h100-eks-inference
  • h100-eks-ubuntu-inference-dynamo
  • h100-eks-ubuntu-inference-nim
  • h100-eks-ubuntu-inference
  • h100-gke-cos-inference-dynamo
  • h100-gke-cos-inference
  • h100-kind-inference-dynamo
  • h100-kind-inference
  • h200-eks-inference
  • rtx-pro-6000-eks-inference
  • rtx-pro-6000-eks-ubuntu-inference-dynamo
  • rtx-pro-6000-eks-ubuntu-inference-nim
  • rtx-pro-6000-eks-ubuntu-inference
  • rtx-pro-6000-lke-inference
  • rtx-pro-6000-lke-ubuntu-inference

This gate is warning-only and never blocks merge. See ADR-007 for the trust model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agentgateway pins to incorrect v2.2.1 release

2 participants