docs(qwen3_8): update NVFP4 checkpoint reference to nvidia/Qwen3.8-27B-NVFP4 - #1389
Conversation
…B-NVFP4 RadixArk/Qwen3.8-27B-NVFP4 and nvidia/Qwen3.8-27B-NVFP4 are the same ModelOpt MIXED_PRECISION export; calibrate_qwen3_8_nvfp4() itself never hardcoded either name, since it reads generic HF tensor names from whatever checkpoint directory is passed in. nvidia's checkpoint is now the one tested against and recommended, so update the three comment/ docstring references that still named RadixArk's mirror. Signed-off-by: Zhenshan Xie <zhenshanx@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/TensorRT-Model-Connect/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummaryUpdates Qwen3.8 documentation and error-message references to NVIDIA’s official Architecture impact
ReviewPASS — No standards or specification violation was found in the reviewed evidence. Review finding counts are unavailable because no current review findings were supplied. Test results were not supplied. WalkthroughChangesQwen3.8 checkpoint naming
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other 🚥 Pre-merge checks | ✅ 9✅ Passed checks (9 passed)
Comment |
Background
families/qwen3_8's NVFP4 code comments and docstrings referencedRadixArk/Qwen3.8-27B-NVFP4as the example checkpoint. NVIDIA has since published its own officialnvidia/Qwen3.8-27B-NVFP4checkpoint -- the same ModelOpt MIXED_PRECISION export, verified byte-identical in structure and behavior (weight loading, build time, engine size, runtime, accuracy) -- and that is now the checkpoint tested against and recommended.Exit Criteria
calibrate_qwen3_8_nvfp4()never hardcoded either checkpoint name (it reads generic HF tensor names from whatevermodel_diris passed in), so this PR is comments/docstrings only.RadixArk/Qwen3.8-27B-NVFP4inquantization.py/checkpoint_mapper.pynow namenvidia/Qwen3.8-27B-NVFP4instead.Implementation
Straightforward string replacement in a module docstring, an inline comment, and a runtime error message.
Change categories
Validation
Commands and Results
ruff check --config ruff.toml families/qwen3_8/quantization.py families/qwen3_8/checkpoint_mapper.py-- all checks passed.git diffreviewed: exactly 3 lines changed, no code logic touched.Hardware, Environment, and Revisions
Not Run / Remaining Gaps
Contributor Self-Review
Notes For Future Readers
None.
Risk level
Comments and docstrings only; no code logic changed.