Skip to content

[None][ci] waive pre-existing test failures on main - #20735

Merged
brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:prbs/waives
Oct 21, 2026
Merged

brnguyen2 merged 1 commit into
NVIDIA:mainfrom
brnguyen2:prbs/waives

Conversation

@brnguyen2

@brnguyen2 brnguyen2 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Waives for pre-existing test failures on main, each with a filed tracking bug. These failures block unrelated PRs; landing the waives here keeps them out of those PRs' diffs.

Test Tracking bug Blocked PR(s)
unittest/_torch/thop/parallel https://nvbugs/6966263 #19465

Maintained by pr-babysitter: entries are pruned automatically as main picks their tests up, and the PR closes itself when nothing is left to carry. The branch is regenerated on each change — do not push to it.

Dev Engineer Review

The change adds a waiver for unittest/_torch/thop/parallel in tests/integration/test_lists/waives.txt, linked to NVBug 6966263. It changes only test gating and introduces no source-code or public API changes. Review findings are unavailable from the supplied evidence.

QA Engineer Review

The change modifies only the waiver list. It suppresses known failures for unittest/_torch/thop/parallel; no test implementation or test ID changed. No test result is supplied. Coverage verdict: needs follow-up because the waiver can hide ongoing failures.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds the unittest/_torch/thop/parallel waiver for NVBug 6966263. The entry is a test-gating change and does not require a CI or manual-QA test-list update.

…s on main; tracking bugs in the PR description)

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 966c62dc-ffd0-49a7-9ff5-3013135d3f41
📥 Commits

Reviewing files that changed from the base of the PR and between 5f90e89 and 0005384.

📒 Files selected for processing: 1
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The integration test waiver list adds unittest/_torch/thop/parallel with skip reason NVBug 6966263.

Changes

Test waiver

Layer / File(s) Summary
Add parallel test waiver
tests/integration/test_lists/waives.txt
The waiver list adds unittest/_torch/thop/parallel with skip reason NVBug 6966263.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: chenfeiz0326

Merge Risk: ⚪ Minimal · up to 00053

The targeted pre-existing test failures are waived as intended, with no remaining merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies a CI waiver for pre-existing test failures on main. It follows the repository format with a None ticket prefix and a concise summary.
Description check Passed The description explains the pre-existing failures, tracking bug, blocked pull request, waiver purpose, and pr-babysitter behavior. It provides sufficient context for this waiver-only change, although…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the pre-existing failures, tracking bug, blocked pull request, waiver purpose, and pr-babysitter behavior. It provides sufficient context for this waiver-only change, although it does not include the full standard section headings or checklist.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #79581 [ run ] triggered by Bot. Commit: 0005384 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #79581 [ run ] completed with state SUCCESS. Commit: 0005384
/LLM/main/L0_MergeRequest_PR pipeline #65529 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@brnguyen2
brnguyen2 enabled auto-merge (squash) October 21, 2026 18:16
@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive only PR"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #79673 [ skip ] triggered by Bot. Commit: 0005384 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #79673 [ skip ] completed with state SUCCESS. Commit: 0005384
Skipping testing for commit 0005384

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants