Skip to content

fix(docker): default untagged images to latest - #4045

Closed
efegokdemir wants to merge 1 commit into
NVIDIA:mainfrom
efegokdemir:fix/docker-bare-image-default-tag
Closed

efegokdemir wants to merge 1 commit into
NVIDIA:mainfrom
efegokdemir:fix/docker-bare-image-default-tag

Conversation

@efegokdemir

Copy link
Copy Markdown

Summary

Default bare Docker image references to the latest tag before sending them to the Engine API.

Related Issue

Fixes #4029

Changes

  • Add :latest when the final image path segment has neither a tag nor a digest.
  • Preserve explicit tags and digests.
  • Treat registry ports such as localhost:5000/image as registry syntax, not as an image tag.
  • Add focused unit coverage for all reference forms.

Testing

  • git diff --check
  • cargo fmt --all -- --check — not run: Cargo is not installed in the local environment.
  • cargo test -p openshell-driver-docker docker_image_reference --lib — not run: Cargo is not installed in the local environment.

Checklist

  • Change is limited to Docker image reference normalization and tests
  • Commit is signed off
  • Focused Rust test run requires CI or a Rust toolchain

Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @efegokdemir.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Docker driver pulls every tag of a repository when --from has no tag

1 participant