Skip to content

fix(installer): honor XDG config home - #4043

Closed
efegokdemir wants to merge 1 commit into
NVIDIA:mainfrom
efegokdemir:fix/installer-xdg-config-home
Closed

efegokdemir wants to merge 1 commit into
NVIDIA:mainfrom
efegokdemir:fix/installer-xdg-config-home

Conversation

@efegokdemir

Copy link
Copy Markdown

Summary

Honor XDG_CONFIG_HOME when the installer locates and updates the local gateway registration and mTLS client bundle.

Related Issue

Fixes #4042

Changes

  • Resolve the target config directory from XDG_CONFIG_HOME, falling back to $HOME/.config when unset or empty.
  • Pass the resolved config directory explicitly to target-user commands.
  • Add installer coverage for unset, empty, set, and set-with-spaces values.

Testing

  • bash tasks/scripts/test-install-sh.sh
  • sh -n install.sh
  • git diff --check

mise run pre-commit was not available because mise is not installed in the local environment.

Checklist

  • Focused tests pass
  • Shell syntax check passes
  • Changes are limited to the installer and its focused tests
  • Commit is signed off

Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Thank you for your interest in contributing to OpenShell, @efegokdemir.

This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer.

To get vouched:

  1. Open a Vouch Request discussion.
  2. Describe what you want to change and why.
  3. Write in your own words — do not have an AI generate the request.
  4. A maintainer will comment /vouch if approved.
  5. Once vouched, open a new PR (preferred) or reopen this one after a few minutes.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot closed this Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@efegokdemir

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

@efegokdemir

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: install.sh ignores XDG_CONFIG_HOME for the local gateway config

1 participant