Conversation
Check required local VM tools through config preflight and share executable resolution with VM image operations. Report selected paths and actionable errors without creating gateway or sandbox state. Bound probe output and execution time, and clean up probe descendants on interruption. Preserve pure static validation and skip local tool checks for remote driver endpoints and unrelated drivers. Fixes #3951 Related to #3955 Signed-off-by: Shiju <shiju@nvidia.com>
Combine identical filesystem-tool error arms and normalize rendered diagnostics in command tests so terminal wrapping preserves assertions. Describe driver TLS validation without depending on removed guest fields. Signed-off-by: Shiju <shiju@nvidia.com>
Keep temporary paths quoted and escaped through the TOML serializer instead of relying on Rust Debug formatting. Signed-off-by: Shiju <shiju@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4037.docs.buildwithfern.com/openshell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openshell-gateway config preflightchecks host filesystem tools for an explicitly selected local VM driver, so an unusable e2fsprogs installation fails before provisioning. The command reports selected paths and versions or a corrective error without creating runtime state.Related Issue
Fixes #3951. Part of #3955.
Changes
openshell-core, preserving the independent VM driver binary. Resolvemke2fsormkfs.ext4,debugfs, ande2fsckfrom the gateway's environment and existing package prefixes, and retain a selected tool's execution failure.PATHvalues. Package installation remains with the operator; this change adds no package dependency or service environment changes.Testing
Branch Checks passed for signed head
8bd564bf637e: all 23 jobs succeeded. Rust lint, tests, and build modes passed on macOS aarch64, Linux aarch64, and Linux x86_64. The gateway feature checks and SDK jobs also passed.mise run pre-commitpasses.Checklist
feat(gateway): validate VM filesystem tools during preflight.