Conversation
Negotiate a launch-authentication requirement and reject incomplete gateway configuration before driver validation, archive consumption or persistence. Validate replacement VM credentials before stopping active compute and prefer explicit signer configuration over local discovery. Closes #3949. Part of #3955. Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4034.docs.buildwithfern.com/openshell |
shiju-nv
marked this pull request as ready for review
October 1, 2026 19:19
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 1, 2026 19:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A VM gateway with listener TLS but no launch signer can download and prepare an image before reporting missing credentials. Check the selected driver's launch-signing requirement before creation reaches driver validation, and reject missing or malformed VM launch credentials before image preparation or state changes. Add the missing signing table to the MicroVM configuration example and explain how to generate a local bundle.
Related Issue
Fixes #3949, accepted by a maintainer on 2026-09-30. Part of #3955.
Changes
openshell.compute.launch-authenticationthrough existing capability negotiation. Drivers that use another launch mechanism can omit it.gateway_jwtconfiguration takes precedence over local bundle discovery. Diagnostics identify the missing or invalid configuration without exposing credentials.config preflightdoes not load signing keys; gateway startup and sandbox admission check launch readiness.Testing
mise run pre-commitpassesChecklist