Skip to content

docs(kubernetes): make helm examples render under the NetworkPolicy ack - #3665

Closed
lunarwhite wants to merge 1 commit into
NVIDIA:mainfrom
lunarwhite:docs/helm-example-ack-flag/lunarwhite
Closed

lunarwhite wants to merge 1 commit into
NVIDIA:mainfrom
lunarwhite:docs/helm-example-ack-flag/lunarwhite

Conversation

@lunarwhite

Copy link
Copy Markdown
Contributor

Summary

Several Helm examples predate the supervisor.sandboxRuntime.networkPolicyEnforced acknowledgement introduced in #2942, and abort as written. templates/network-policy-ack.yaml calls fail until that value is true, and the chart defaults it to false. Without this fix, the 0.1.0 docs publish these commands as they are.

Related Issue

N/A. Localized docs fix correcting examples that cannot run as written.

Changes

  • docs/kubernetes/access-control.mdx, docs/kubernetes/ingress.mdx, docs/kubernetes/openshift.mdx: add --set supervisor.sandboxRuntime.networkPolicyEnforced=true to the examples that omit it, positioned as the first --set after --namespace to match the examples feat(isolation): implement the RFC 0012 sandbox architecture #2942 already updated in the same files.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated — N/A, documentation only
  • E2E tests added/updated (if applicable) — N/A, no e2e/ change

mise run markdown:lint reports 0 errors. A repo-wide audit of every helm install and helm upgrade against the gateway chart across docs/ and deploy/ now finds none that would trip the acknowledgement gate.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable) — N/A

Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lunarwhite

Copy link
Copy Markdown
Contributor Author

cc @drew
This is a followup docs-only fix to #2942, I came across this inconsistency breakage while walking thru docs site randomly.

@drew drew self-assigned this Sep 24, 2026
@lunarwhite

Copy link
Copy Markdown
Contributor Author

closing in favor of #3677

@lunarwhite lunarwhite closed this Sep 24, 2026
@lunarwhite
lunarwhite deleted the docs/helm-example-ack-flag/lunarwhite branch September 24, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants