docs(kubernetes): make helm examples render under the NetworkPolicy ack - #3665
Closed
lunarwhite wants to merge 1 commit into
Closed
lunarwhite wants to merge 1 commit into
lunarwhite wants to merge 1 commit into
Conversation
Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
lunarwhite
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 24, 2026 16:08
Contributor
Author
5 of 6 tasks
Contributor
Author
|
closing in favor of #3677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several Helm examples predate the
supervisor.sandboxRuntime.networkPolicyEnforcedacknowledgement introduced in #2942, and abort as written.templates/network-policy-ack.yamlcallsfailuntil that value istrue, and the chart defaults it tofalse. Without this fix, the 0.1.0 docs publish these commands as they are.Related Issue
N/A. Localized docs fix correcting examples that cannot run as written.
Changes
docs/kubernetes/access-control.mdx,docs/kubernetes/ingress.mdx,docs/kubernetes/openshift.mdx: add--set supervisor.sandboxRuntime.networkPolicyEnforced=trueto the examples that omit it, positioned as the first--setafter--namespaceto match the examples feat(isolation): implement the RFC 0012 sandbox architecture #2942 already updated in the same files.Testing
mise run pre-commitpassese2e/changemise run markdown:lintreports 0 errors. A repo-wide audit of everyhelm installandhelm upgradeagainst the gateway chart acrossdocs/anddeploy/now finds none that would trip the acknowledgement gate.Checklist