fix(vm): look for e2fsprogs tools in /usr/sbin and /sbin - #3477
Open
natedemoss wants to merge 3 commits into
Open
natedemoss wants to merge 3 commits into
natedemoss wants to merge 3 commits into
Conversation
natedemoss
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 19, 2026 01:51
drew
previously approved these changes
Sep 23, 2026
Collaborator
|
/ok to test a48253c |
drew
enabled auto-merge
September 23, 2026 04:58
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 23, 2026
The VM driver only checked PATH and the Homebrew e2fsprogs dirs for mke2fs, e2fsck and debugfs. On Linux these live in /usr/sbin or /sbin, which usually isn't on a regular user's PATH, so provisioning failed with "mke2fs not found" even with e2fsprogs installed. Add /usr/local/sbin, /usr/sbin and /sbin to the search list. macOS behavior is unchanged. Closes NVIDIA#3400 Signed-off-by: natedemoss <ndemoss28@gmail.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
ext4_image_has_directory landed on main in NVIDIA#3524 using the removed e2fs_tool_candidates helper. Route it and its test through e2fs_command so it uses the same PATH lookup as the other e2fsprogs callers. Signed-off-by: Nathan DeMoss <ndemoss28@gmail.com>
natedemoss
force-pushed
the
fix/vm-e2fsprogs-system-sbin-lookup
branch
from
September 23, 2026 18:54
a48253c to
8c35425
Compare
Contributor
Author
|
Rebased onto main to fix the merge queue failure. #3524 added |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix VM provisioning when e2fsprogs is installed outside a regular user's
PATH.Related Issue
Closes #3400
Changes
PATHand append platform-specific e2fsprogs directories for each subprocess.PATHonce instead of retrying alternate copies after an execution failure.Testing
cargo test -p openshell-driver-vmmise run pre-commitChecklist