fix(dev): extract Docker sandbox runtime from sandbox image - #3422
Merged
Merged
Conversation
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
johntmyers
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 17, 2026 17:52
pimlock
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
mise run gateway:dockeron macOS and other cross-compilation hosts after the supervisor/runtime split in #2942. Setup exported the supervisor image and then failed copyingopenshell-sandbox, because that image now containsopenshell-supervisor. Extract the workload runtime from the sandbox image instead.Related Issue
No issue required: an obvious localized correction to the Docker development build target after #2942.
Changes
sandboxDocker build target when exportingopenshell-sandboxfor the local Docker driver.Testing
mise run pre-commitpassesbash -n tasks/scripts/gateway-docker.shbash tasks/scripts/test-gateway-pull-policy.sh--versionin a container.mise run gateway:dockerfrom this worktree: sandbox reached Ready, workload ran exactly once, supervisor was healthy, both containers had zero restarts, CLI exec succeeded as non-root, and deletion removed both containers.No new unit tests: the change selects the existing sandbox build target. Full local CI was not run; remote CI will provide broader coverage.
Checklist